Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openscenegraph: 3.4.0 -> 3.6.2 #44942

Merged
merged 1 commit into from Aug 13, 2018
Merged

openscenegraph: 3.4.0 -> 3.6.2 #44942

merged 1 commit into from Aug 13, 2018

Conversation

aanderse
Copy link
Member

Looking for approval by @7c6f434c as they are the maintainer.

Motivation for this change

version bump

Things done

bumped openscenegraph version from 3.4 to 3.6.2 and added more options for building it

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@7c6f434c
Copy link
Member

@GrahamcOfBorg build openmodelica

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: openmodelica

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: openmodelica

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: openmodelica

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@xeji
Copy link
Contributor

xeji commented Aug 12, 2018

This depends on openmodelica which is marked as broken, so you would have to un-break that first.

@aanderse
Copy link
Member Author

@xeji I'm sorry I'm not seeing what is pulling in this openmodelica dependency?

I tried adding openscenegraph_3_6_2 as the package in my ~/.config/nixpkgs/config.nix and then calling nix-store --query --references (nix-instantiate '' -A openscenegraph_3_6_2) but I still don't see what is pulling it in... Any help?

@7c6f434c
Copy link
Member

No, that was my attempt to test a random rev-dep, I guessed wrong

@7c6f434c
Copy link
Member

@GrahamcOfBorg build openmw

@7c6f434c
Copy link
Member

Maybe better luck this way?

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: openmw

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: openmw

Partial log (click to expand)

shrinking /nix/store/bgc3pkd4lsf3ypdfwby2dadv2hch98b5-openmw-0.43.0/bin/esmtool
shrinking /nix/store/bgc3pkd4lsf3ypdfwby2dadv2hch98b5-openmw-0.43.0/bin/openmw-iniimporter
shrinking /nix/store/bgc3pkd4lsf3ypdfwby2dadv2hch98b5-openmw-0.43.0/bin/openmw-cs
shrinking /nix/store/bgc3pkd4lsf3ypdfwby2dadv2hch98b5-openmw-0.43.0/bin/openmw-essimporter
shrinking /nix/store/bgc3pkd4lsf3ypdfwby2dadv2hch98b5-openmw-0.43.0/bin/bsatool
shrinking /nix/store/bgc3pkd4lsf3ypdfwby2dadv2hch98b5-openmw-0.43.0/bin/openmw
strip is /nix/store/gpc2wld1s0c6qzx9326cwn1wcx29xzsj-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/bgc3pkd4lsf3ypdfwby2dadv2hch98b5-openmw-0.43.0/bin
patching script interpreter paths in /nix/store/bgc3pkd4lsf3ypdfwby2dadv2hch98b5-openmw-0.43.0
checking for references to /build in /nix/store/bgc3pkd4lsf3ypdfwby2dadv2hch98b5-openmw-0.43.0...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: openmw

Partial log (click to expand)

shrinking /nix/store/bipfk9av27vfp42hl480486kh90m8zba-openmw-0.43.0/bin/openmw-iniimporter
shrinking /nix/store/bipfk9av27vfp42hl480486kh90m8zba-openmw-0.43.0/bin/esmtool
shrinking /nix/store/bipfk9av27vfp42hl480486kh90m8zba-openmw-0.43.0/bin/bsatool
shrinking /nix/store/bipfk9av27vfp42hl480486kh90m8zba-openmw-0.43.0/bin/openmw-launcher
shrinking /nix/store/bipfk9av27vfp42hl480486kh90m8zba-openmw-0.43.0/bin/openmw
strip is /nix/store/ah0va6j4cnwj9nx4j6rwcfc8nh785jwm-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/bipfk9av27vfp42hl480486kh90m8zba-openmw-0.43.0/bin
patching script interpreter paths in /nix/store/bipfk9av27vfp42hl480486kh90m8zba-openmw-0.43.0
checking for references to /build in /nix/store/bipfk9av27vfp42hl480486kh90m8zba-openmw-0.43.0...
/nix/store/bipfk9av27vfp42hl480486kh90m8zba-openmw-0.43.0

@7c6f434c 7c6f434c merged commit 3762495 into NixOS:master Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aanderse @7c6f434c @GrahamcOfBorg @xeji