Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dirOf: allow use on non-absolute paths #2349

Merged
merged 1 commit into from Sep 13, 2018
Merged

dirOf: allow use on non-absolute paths #2349

merged 1 commit into from Sep 13, 2018

Conversation

lheckemann
Copy link
Member

Fixes #2251

@lheckemann lheckemann mentioned this pull request Aug 13, 2018
Closed
@lheckemann
Copy link
Member Author

@edolstra any objection to this?

@grahamc
Copy link
Member

grahamc commented Sep 13, 2018

He objected here: #2251 (comment)

@lheckemann
Copy link
Member Author

No, that's an objection to resolving paths relative to the cwd. However, as implemented here, it's completely pure as discussed later in that issue.

@edolstra edolstra merged commit d7402c9 into NixOS:master Sep 13, 2018
@edolstra
Copy link
Member

Thanks, merged!

@lheckemann lheckemann deleted the dirOf-relative branch September 13, 2018 12:47
@uvNikita uvNikita mentioned this pull request Oct 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lheckemann @grahamc @edolstra