Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blastem: init at 0.5.1 #44956

Merged
merged 1 commit into from Sep 25, 2018
Merged

blastem: init at 0.5.1 #44956

merged 1 commit into from Sep 25, 2018

Conversation

puffnfresh
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@ryantm
Copy link
Member

ryantm commented Aug 31, 2018

@GrahamcOfBorg build blastem

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: blastem

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: blastem

Partial log (click to expand)

gcc -o blastem blastem.o system.o genesis.o debug.o gdb_remote.o vdp.o render_sdl.o ppm.o io.o romdb.o hash.o menu.o xband.o realtec.o i2c.o nor.o sega_mapper.o multi_game.o serialize.o terminal.o config.o tern.o util.o gst.o 68kinst.o m68k_core.o m68k_core_x86.o gen.o backend.o mem.o arena.o gen_x86.o backend_x86.o ym2612.o psg.o wave.o sms.o z80inst.o z80_to_x86.o -O2 -flto -lm -L/nix/store/2bqr2gs50csfn8p6z45a50lrji0nm7q9-SDL2-2.0.8/lib -L/nix/store/s82b9b9mm7lhx2sr3w9rcd6r1yxl5ncl-libglvnd-1.0.0/lib -L/nix/store/53apw743zpvq0pyf5laq98n76vghkjcz-glew-2.1.0/lib -L/nix/store/vh0vfimr2ayjrygz88zy2wyg8wb9c2m1-glu-9.0.0/lib -Wl,-rpath,/nix/store/2bqr2gs50csfn8p6z45a50lrji0nm7q9-SDL2-2.0.8/lib -Wl,--enable-new-dtags -lSDL2 -lGLEW -lGLU -lGL -m64
true ./blastem
gcc -O2 -flto -I/nix/store/xrl7qdizi75q7cc7wzz8nbncz8733z00-SDL2-2.0.8-dev/include/SDL2 -I/nix/store/ch9625za0imx3dliphqna395779l46w9-mesa-noglu-18.1.5-dev/include -I/nix/store/x6zj2xpkj7wlijjajrxx9nqcp3f66hm1-glew-2.1.0-dev/include -I/nix/store/n0jg162x004jfffbai20m3pm2rwljlyq-glu-9.0.0-dev/include -std=gnu99 -Wreturn-type -Werror=return-type -Werror=implicit-function-declaration -Wno-unused-value  -DX86_64 -m64  -O2 -flto -lm -L/nix/store/2bqr2gs50csfn8p6z45a50lrji0nm7q9-SDL2-2.0.8/lib -L/nix/store/s82b9b9mm7lhx2sr3w9rcd6r1yxl5ncl-libglvnd-1.0.0/lib -L/nix/store/53apw743zpvq0pyf5laq98n76vghkjcz-glew-2.1.0/lib -L/nix/store/vh0vfimr2ayjrygz88zy2wyg8wb9c2m1-glu-9.0.0/lib -Wl,-rpath,/nix/store/2bqr2gs50csfn8p6z45a50lrji0nm7q9-SDL2-2.0.8/lib -Wl,--enable-new-dtags -lSDL2 -lGLEW -lGLU -lGL -m64  termhelper.c   -o termhelper
/bin/sh: /bin/echo: not found
xcf2png font_interlace_variable.xcf > font_interlace_variable.png
./img2tiles.py -s font_interlace_variable.spec font_interlace_variable.tiles
make: ./img2tiles.py: Command not found
make: *** [Makefile:236: font_interlace_variable.tiles] Error 127
builder for '/nix/store/ackpz07frgy7a0277fw5pdm80zcz72y2-blastem-0.5.1.drv' failed with exit code 2
error: build of '/nix/store/ackpz07frgy7a0277fw5pdm80zcz72y2-blastem-0.5.1.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: blastem

Partial log (click to expand)

setting SOURCE_DATE_EPOCH to timestamp 1504081324 of file blastem-3d48cb0c28be/ztestrun.c
patching sources
updateAutotoolsGnuConfigScriptsPhase
configuring
no configure script, doing nothing
building
/bin/sh: /bin/echo: not found
Makefile:140: *** aarch64 is not a supported architecture.  Stop.
builder for '/nix/store/08960nbvfkn8ddj7dcsz5f9hgnsi25l2-blastem-0.5.1.drv' failed with exit code 2
error: build of '/nix/store/08960nbvfkn8ddj7dcsz5f9hgnsi25l2-blastem-0.5.1.drv' failed

ryantm
ryantm requested changes Sep 1, 2018
View reviewed changes
Copy link
Member

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the build

@puffnfresh
Copy link
Contributor Author

Does ofborg not have /usr/bin/env? I can't reproduce the failure on my NixOS systems.

@ryantm
Copy link
Member

ryantm commented Sep 24, 2018

I can reproduce with nix-build --option sandbox true -A blastem

...
true ./blastem
gcc -O2 -flto -I/nix/store/cbcbqfpjkxpidsqv3r7w7slgik7fwx93-SDL2-2.0.8-dev/include/SDL2 -I/nix/store/4x4l8q7qisjg1gabvpq99cypr646sfgb-mesa-noglu-18.1.5-dev/\
include -I/nix/store/2yabd23z60jjgw1bvbnmmjlcp58xx2nw-glew-2.1.0-dev/include -I/nix/store/bil4p8ry2haarf1yhcz5vy9m0jwxnzcs-glu-9.0.0-dev/include -std=gnu99 \
-Wreturn-type -Werror=return-type -Werror=implicit-function-declaration -Wno-unused-value  -DX86_64 -m64  -O2 -flto -lm -L/nix/store/b028c6ax8622375lp2gjc3q\
6xznpkdbr-SDL2-2.0.8/lib -L/nix/store/3v1rcfkyzrf07vhij95cy9j72qx63y5j-libglvnd-1.0.0/lib -L/nix/store/v50b6limw49rcg686akm4aidxrawmymf-glew-2.1.0/lib -L/ni\
x/store/h2ipbyqfg712x16qsagpanybpxs3249r-glu-9.0.0/lib -Wl,-rpath,/nix/store/b028c6ax8622375lp2gjc3q6xznpkdbr-SDL2-2.0.8/lib -Wl,--enable-new-dtags -lSDL2 -\
lGLEW -lGLU -lGL -m64  termhelper.c   -o termhelper
/bin/sh: /bin/echo: not found
xcf2png font_interlace_variable.xcf > font_interlace_variable.png
./img2tiles.py -s font_interlace_variable.spec font_interlace_variable.tiles
make: ./img2tiles.py: Command not found
make: *** [Makefile:236: font_interlace_variable.tiles] Error 127
builder for '/nix/store/h8cnfldwg9v8g41l565biy08ln95damh-blastem-0.5.1.drv' failed with exit code 2
error: build of '/nix/store/h8cnfldwg9v8g41l565biy08ln95damh-blastem-0.5.1.drv' failed

@puffnfresh
Copy link
Contributor Author

@ryantm thanks. I didn't realise the sandbox doesn't have /usr!

Fixed the problem.

@ryantm
Copy link
Member

ryantm commented Sep 25, 2018

@GrahamcOfBorg build blastem

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: blastem

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: blastem

Partial log (click to expand)

configuring
no configure script, doing nothing
building
patching script interpreter paths in img2tiles.py
img2tiles.py: interpreter directive changed from "/usr/bin/env python" to "/nix/store/bp1c65zbbw6jfjws77pbgw48mjfmk9x3-python-2.7.15/bin/python"
build flags: SHELL=/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/bash
/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/bash: /bin/echo: No such file or directory
Makefile:140: *** aarch64 is not a supported architecture.  Stop.
builder for '/nix/store/0a16d43ndmnyfd7m54prm5naycj4m2s7-blastem-0.5.1.drv' failed with exit code 2
error: build of '/nix/store/0a16d43ndmnyfd7m54prm5naycj4m2s7-blastem-0.5.1.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: blastem

Partial log (click to expand)

CODE(acrx2):           13710 bytes
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/8z4l96mclh4gaa7p6bs39cnijfmrxh33-blastem-0.5.1
shrinking /nix/store/8z4l96mclh4gaa7p6bs39cnijfmrxh33-blastem-0.5.1/share/blastem/blastem
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/8z4l96mclh4gaa7p6bs39cnijfmrxh33-blastem-0.5.1/bin
patching script interpreter paths in /nix/store/8z4l96mclh4gaa7p6bs39cnijfmrxh33-blastem-0.5.1
checking for references to /build in /nix/store/8z4l96mclh4gaa7p6bs39cnijfmrxh33-blastem-0.5.1...
/nix/store/8z4l96mclh4gaa7p6bs39cnijfmrxh33-blastem-0.5.1

@ryantm ryantm merged commit 8d865c9 into NixOS:master Sep 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@puffnfresh @ryantm @GrahamcOfBorg