Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plex-media-player: init at 2.14.1 #43839

Merged
merged 1 commit into from Aug 4, 2018
Merged

plex-media-player: init at 2.14.1 #43839

merged 1 commit into from Aug 4, 2018

Conversation

kylewlacy
Copy link
Contributor

Motivation for this change

This PR adds the official "next generation" Plex Media Player client. It pairs well with plex-media-server, which is already in Nixpkgs!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

(PMP's build system is fairly complicated since it downloads CMake bundles that download other files at build time. In the same vein as the AUR pacakge, and to ensure the build works during sandboxed builds, all of the downloaded files are fetched before building, using fetchurl. If anyone has any suggestions for refactoring the preConfigure step, I'm open to ideas!)

@xeji
Copy link
Contributor

xeji commented Aug 4, 2018

@GrahamcOfBorg build plex-media-player

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: plex-media-player

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/ar8c78ljwi5nyz3cfw1y3ib5aiy5c89x-plex-media-player-2.14.1.880
shrinking /nix/store/ar8c78ljwi5nyz3cfw1y3ib5aiy5c89x-plex-media-player-2.14.1.880/bin/plexmediaplayer
shrinking /nix/store/ar8c78ljwi5nyz3cfw1y3ib5aiy5c89x-plex-media-player-2.14.1.880/bin/pmphelper
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ar8c78ljwi5nyz3cfw1y3ib5aiy5c89x-plex-media-player-2.14.1.880/bin
patching script interpreter paths in /nix/store/ar8c78ljwi5nyz3cfw1y3ib5aiy5c89x-plex-media-player-2.14.1.880
checking for references to /build in /nix/store/ar8c78ljwi5nyz3cfw1y3ib5aiy5c89x-plex-media-player-2.14.1.880...
postPatchMkspecs
/nix/store/ar8c78ljwi5nyz3cfw1y3ib5aiy5c89x-plex-media-player-2.14.1.880

@xeji xeji merged commit 8706906 into NixOS:master Aug 4, 2018
@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: plex-media-player

Partial log (click to expand)

cannot build derivation '/nix/store/s7mrw4kyszbj5wjym0gy84qb1lzsdnf2-qtx11extras-5.9.3.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/isk6xg63arkjqnvlavpaf7yc0l5ff3f3-qtxmlpatterns-5.9.3.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/x7z9rsliifaqllfa5g1bndiw2g08k9wf-qtdeclarative-5.9.3.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/m97c2yybdif3v1b0v3nz1d73w6vvwnrd-qtmultimedia-5.9.3.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/n5bz9k8f5siypsy0m3m9z5pdids0wdb7-qtquickcontrols-5.9.3.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/vyr8agyjcmbrxrzfkj09k1vvs3079xid-qtwebchannel-5.9.3.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/103ls9d8axm6klnj6gnpwcwm7b5hv6m2-qtlocation-5.9.3.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/mp7wvjcxl1a5zjhm2parn8r3wb8a1bqk-qtwebengine-5.9.3.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/88dap1dhqisppgj0cxrlyk6dg3h1xz38-plex-media-player-2.14.1.880.drv': 4 dependencies couldn't be built
error: build of '/nix/store/88dap1dhqisppgj0cxrlyk6dg3h1xz38-plex-media-player-2.14.1.880.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: plex-media-player

Partial log (click to expand)

./media/tools/layout_tests/layouttest_analyzer_helpers_unittest.py: interpreter directive changed from "/usr/bin/env python" to "/nix/store/x808ih1lb5bkzk4w1wj054hpa0xyx4cj-python-2.7.15/bin/python"
./media/tools/constrained_network_server/cns.py: interpreter directive changed from "/usr/bin/env python" to "/nix/store/x808ih1lb5bkzk4w1wj054hpa0xyx4cj-python-2.7.15/bin/python"
./media/tools/constrained_network_server/cn.py: interpreter directive changed from "/usr/bin/env python" to "/nix/store/x808ih1lb5bkzk4w1wj054hpa0xyx4cj-python-2.7.15/bin/python"
./media/tools/constrained_network_server/traffic_control_unittest.py: interpreter directive changed from "/usr/bin/env python" to "/nix/store/x808ih1lb5bkzk4w1wj054hpa0xyx4cj-python-2.7.15/bin/python"
./media/tools/constrained_network_server/cns_test.py: interpreter directive changed from "/usr/bin/env python" to "/nix/store/x808ih1lb5bkzk4w1wj054hpa0xyx4cj-python-2.7.15/bin/python"
./media/tools/constrained_network_server/traffic_control_test.py: interpreter directive changed from "/usr/bin/env python" to "/nix/store/x808ih1lb5bkzk4w1wj054hpa0xyx4cj-python-2.7.15/bin/python"
substitute(): ERROR: file 'mkspecs/features/platform.prf' does not exist
builder for '/nix/store/wz71zr4zmxxcl2h4rg4b9qfx6i59jn9h-qtwebengine-5.9.3.drv' failed with exit code 1
cannot build derivation '/nix/store/9ahafzfbc4cpi5skh6k1s2c41j4mqbfw-plex-media-player-2.14.1.880.drv': 1 dependencies couldn't be built
error: build of '/nix/store/9ahafzfbc4cpi5skh6k1s2c41j4mqbfw-plex-media-player-2.14.1.880.drv' failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kylewlacy @xeji @GrahamcOfBorg