pssh: ensure runtime dependencies are propagated #43820
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flokli
requested changes
Jul 19, 2018
| @@ -20,6 +20,8 @@ pythonPackages.buildPythonApplication rec { | |||
| done | |||
| ''; | |||
|
|
|||
| propagatedBuildDependencies = [ openssh rsync ]; | |||
There was a problem hiding this comment.
that would be called propagatedBuildInputs - and given these two are already specified explicitly in bin/* after postPatch, they should be automatically added as runtime dependencies:
If the build was successful, Nix scans each output path for references to input paths by looking for the hash parts of the input paths. Since these are potential runtime dependencies, Nix registers them as dependencies of the output paths.
|
I realize this isn't necessary — I was encountering a problem in which prsync wasn't finding rsync, and assumed I needed to make rsync a dependency, but I now realize it was just because I had a |
|
ok :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Makes sure that
opensshandrsyncare present when runningpsshorprsync. These tools give very confusing error messages if they aren't.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)