perkeep: 20170505 -> 0.10.1 #43840
perkeep: 20170505 -> 0.10.1 #43840
Conversation
| sha256 = "1pchwizx1sdli59g8r0p4djfjkchcvh8msfpp3ibvz3xl250jh0n"; | ||
| }; | ||
|
|
||
| in | ||
| stdenv.mkDerivation rec { |
There was a problem hiding this comment.
Can you use buildGoPackage here? Otherwise the result will depend on the go compiler at runtime.
There was a problem hiding this comment.
Sure, let me give that a try, I'll ping you once I addressed your comment. Thx @Mic92 for the review!
| cp -a ${gotool} ./vendor/github.com/kisielk/gotool | ||
| mkdir -p ./vendor/golang.org/x/tools/go | ||
| cp -a ${gcimporter15}/go/gcimporter15 ./vendor/golang.org/x/tools/go/gcimporter15 | ||
| buildInputs = [ git go ]; |
There was a problem hiding this comment.
It does not look like it was strictly required: https://perkeep.googlesource.com/perkeep/+/master/make.go#668
There was a problem hiding this comment.
Nice catch, I will remove git as a dependency.
kalbasit
force-pushed
the
update_perkeep
branch
2 times, most recently
from
b733968
to
2fc646c
Compare
|
|
||
| buildInputs = [ git go ]; | ||
| buildInputs = [ go ]; |
There was a problem hiding this comment.
@Mic92 go was imported in the stdenv.mkDerivation because perkeep insists on using a specific version of Go. How to tell buildGoPackage to use a specific version of Go? It's always adding go to both nativeBuildInputs and buildInputs, so I'm not sure that my setting it here actually makes it use this go version or not.
There was a problem hiding this comment.
Use buildGo110Package instead of buildGoPackage for example
kalbasit
force-pushed
the
update_perkeep
branch
3 times, most recently
from
5b112f0
to
f79997a
Compare
Also rewrite the derivation to use buildGoPackage
|
@Mic92 PTAL. |
Motivation for this change
Updating perkeep to the latest version
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)cc @cstrahan