[wip] {cc,bintools}-wrapper: handle $out/nix-support/skip-flags #43818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a new flag that is checked to prevent the wrappers from adding
CFLAGS & LDFLAGS. It should be used sparingly but in the case of
Haskell packages, it is necessary to avoid hitting ARG_MAX limits.
Haskell has its own way of handling deps which is done in
generic-builder.nix. Skipping the {C,LD}FLAGS is a harmless way to
reduce ARG_MAX.
Related to PR NixOS#43713.
/cc @angerman @Ericson2314 @peti
matthewbauer
force-pushed
the
nix-support-skip-flags
branch
from
2730c10
to
e9e9891
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new flag that is checked to prevent the wrappers from adding
CFLAGS & LDFLAGS. It should be used sparingly but in the case of
Haskell packages, it is necessary to avoid hitting ARG_MAX limits.
Haskell has its own way of handling deps which is done in
generic-builder.nix. Skipping the {C,LD}FLAGS is a harmless way to
reduce ARG_MAX.
Related to PR #43713.
/cc @angerman @Ericson2314 @peti
This is still a work in progress. Unfortunately it is a mass-rebuild so it could take a while. I am still waiting on building the stdenv. It should accomplish the same thing as PR #43713 with the upside of avoiding the need to move the ```--libdir`` flag.