Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

why3: 0.88.3 -> 1.0.0 #43819

Closed
wants to merge 1 commit into from
Closed

why3: 0.88.3 -> 1.0.0 #43819

wants to merge 1 commit into from

Conversation

wizeman
Copy link
Member

@wizeman wizeman commented Jul 19, 2018

Motivation for this change

Update why3 from 0.88.3 to 1.0.0.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: why3

Partial log (click to expand)

cannot build derivation '/nix/store/099bvwpqc64vpda2lrn2glvv14r10xhd-gdk-pixbuf-2.36.12.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/ksz2abf66crhbjhjgab6cqv1ly6yf14n-gtk+-2.24.32.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/jy60wh6i7haf9awm54w7wmld320m1fg4-gtksourceview-2.10.5.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/v77k0lc7q8bdr1b3v007bcd0z01njjj3-libglade-2.6.4.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/4anj35k450f78acbrqdpq955wkhjr5yn-libgnomecanvas-2.30.3.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/6mf4b3l4nik2v62srwmj1llchyqx5pbb-lablgtk-2.18.5.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/my1pgn7p9n35xjqsjdbaw5r91xijjr9i-coq-8.7.2.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/174i0ivbx97kr2yshfdazw4j97vi21cw-ocamlgraph-1.8.8.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/a83nznn953qb26cz9qpfzqkvs9jl9w0l-why3-1.0.0.drv': 3 dependencies couldn't be built
error: build of '/nix/store/a83nznn953qb26cz9qpfzqkvs9jl9w0l-why3-1.0.0.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: why3

Partial log (click to expand)

checking for rubber... no
configure: WARNING: Cannot find rubber, documentation disabled.
checking for emacs... no
configure: WARNING: Cannot find emacs, compilation of why3.elc disabled.
ocamlfind: Package `num' not found
checking for /nix/store/gcz04mmiya8hl9nlqs1pz56ll6arwn5r-ocaml-4.06.1/lib/ocaml/nums.cma... no
checking for /nix/store/gcz04mmiya8hl9nlqs1pz56ll6arwn5r-ocaml-4.06.1/lib/ocaml/num.cmi... no
configure: error: Library Num not found.
builder for '/nix/store/mwfalgk6zjkf87lcl31k1c4ibmbx8bmz-why3-1.0.0.drv' failed with exit code 1
error: build of '/nix/store/mwfalgk6zjkf87lcl31k1c4ibmbx8bmz-why3-1.0.0.drv' failed

@vbgl
Copy link
Contributor

vbgl commented Jul 21, 2018

@GrahamcOfBorg build why3

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: why3

Partial log (click to expand)

shrinking /nix/store/nizca2p4f81spi6klh8z7hg1liaib93h-why3-1.0.0/lib/why3/commands/why3config
shrinking /nix/store/nizca2p4f81spi6klh8z7hg1liaib93h-why3-1.0.0/lib/why3/commands/why3execute
shrinking /nix/store/nizca2p4f81spi6klh8z7hg1liaib93h-why3-1.0.0/lib/ocaml/4.05.0/site-lib/why3/why3.cmxs
shrinking /nix/store/nizca2p4f81spi6klh8z7hg1liaib93h-why3-1.0.0/lib/ocaml/4.05.0/site-lib/why3/why3extract.cmxs
strip is /nix/store/90vmpr41dzsx350k5argycaf693hnl1l-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/nizca2p4f81spi6klh8z7hg1liaib93h-why3-1.0.0/lib  /nix/store/nizca2p4f81spi6klh8z7hg1liaib93h-why3-1.0.0/bin
patching script interpreter paths in /nix/store/nizca2p4f81spi6klh8z7hg1liaib93h-why3-1.0.0
/nix/store/nizca2p4f81spi6klh8z7hg1liaib93h-why3-1.0.0/lib/why3/why3-call-pvs: interpreter directive changed from "/bin/sh" to "/nix/store/z9qg7lpkrajdnlgw5pxp9yx984prl1fi-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/nizca2p4f81spi6klh8z7hg1liaib93h-why3-1.0.0...
/nix/store/nizca2p4f81spi6klh8z7hg1liaib93h-why3-1.0.0

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: why3

Partial log (click to expand)

checking for rubber... no
configure: WARNING: Cannot find rubber, documentation disabled.
checking for emacs... no
configure: WARNING: Cannot find emacs, compilation of why3.elc disabled.
ocamlfind: Package `num' not found
checking for /nix/store/gcz04mmiya8hl9nlqs1pz56ll6arwn5r-ocaml-4.06.1/lib/ocaml/nums.cma... no
checking for /nix/store/gcz04mmiya8hl9nlqs1pz56ll6arwn5r-ocaml-4.06.1/lib/ocaml/num.cmi... no
configure: error: Library Num not found.
builder for '/nix/store/mwfalgk6zjkf87lcl31k1c4ibmbx8bmz-why3-1.0.0.drv' failed with exit code 1
error: build of '/nix/store/mwfalgk6zjkf87lcl31k1c4ibmbx8bmz-why3-1.0.0.drv' failed

@vbgl
Copy link
Contributor

vbgl commented Jul 21, 2018

Merged in 0cf0955. I also added num to the build inputs.

@vbgl vbgl closed this Jul 21, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: why3

Partial log (click to expand)

        lib/why3/META /nix/store/85ldjylddm7y18a3pfpf80b4sqb55jaa-why3-1.0.0/lib/ocaml/4.05.0/site-lib//why3
/nix/store/4biv886kklq2jbx8ca23krwn66kcp53a-coreutils-8.29/bin/mkdir -p /nix/store/85ldjylddm7y18a3pfpf80b4sqb55jaa-why3-1.0.0/lib/ocaml/4.05.0/site-lib//why3
/nix/store/4biv886kklq2jbx8ca23krwn66kcp53a-coreutils-8.29/bin/install -c -m 644 lib/why3/why3extract.a lib/why3/why3extract.cmx lib/why3/why3extract.cmi lib/why3/why3extract.cmxa lib/why3/why3extract.cmxs \
  /nix/store/85ldjylddm7y18a3pfpf80b4sqb55jaa-why3-1.0.0/lib/ocaml/4.05.0/site-lib//why3
post-installation fixup
strip is /nix/store/8axizw5mf6dx7wip65nbkyrmlkhmjhc5-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/85ldjylddm7y18a3pfpf80b4sqb55jaa-why3-1.0.0/lib  /nix/store/85ldjylddm7y18a3pfpf80b4sqb55jaa-why3-1.0.0/bin
patching script interpreter paths in /nix/store/85ldjylddm7y18a3pfpf80b4sqb55jaa-why3-1.0.0
/nix/store/85ldjylddm7y18a3pfpf80b4sqb55jaa-why3-1.0.0/lib/why3/why3-call-pvs: interpreter directive changed from "/bin/sh" to "/nix/store/mdzgfbangzw62b6cb48dg0q83sxdy12y-bash-4.4-p23/bin/sh"
/nix/store/85ldjylddm7y18a3pfpf80b4sqb55jaa-why3-1.0.0

@wizeman
Copy link
Member Author

wizeman commented Jul 23, 2018

@vbgl AFAICS, num is not needed as long as zarith is available, since the latter is preferred.

@vbgl
Copy link
Contributor

vbgl commented Jul 23, 2018

The configure script will fail if num cannot be found, even if zarith is there. Is it a bug to report upstream?

@wizeman
Copy link
Member Author

wizeman commented Jul 23, 2018

Ah, I think I was incorrect: I can see in the configure script that zarith can replace num, but it seems that even then, num is still required. Perhaps num was somehow being propagated on x86-64 and that's why the configure script didn't fail for me, even though num wasn't explicitly added to the buildInputs.

So I think you were right in adding num. Thanks and sorry for the noise!

@wizeman wizeman deleted the u/upd-why3 branch August 31, 2018 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wizeman @GrahamcOfBorg @vbgl