AGOS: Add in game loading/Saving via GMM #1256
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Once the engine has been started and the game is at a safe place to save/load (as determined by quickLoadOrSave()) the player can save/load their game using the GMM. Currently, the save descriptor shown in the listsaves is the filename, but the actual correct descriptor is correct in the save when saving via the GMM. The descriptor saved using the GMM can be seen using the original game save/load menus. The displaying of the correct descriptor can be added later. The filenames shown by listsaves is generated from the input target which can be one of several games. Most of them are just the basename so the target simon2-cd-win is just simon2.xxx for the savefile, but for waxworks and elvira2 they differ on whether the platform is dos or amiga. Since the target does not contain this information I am currently not differentiating the two, so I defaulted it to generate names based on the dos version. This can also be changed later. For amiga waxworks and elvira2 this has the effect that saved games cannot be loaded/seen using listsaves. They will be correctly saved when saving via the GMM since that does not use the savefile name generated from the target. I've tested this with waxworks dos, simon1 dos and simon2 dos.
|
The current quick load and save code in the AGOS engine is a hack at best, and I still don't consider it a safe method to use. It was only added long ago for console ports, lacking the keyboard. We currently just copy various script segments and hope for the best when loading and saving. I'm rejecting this pull request, as these changes are just too risky. |
|
If anyone is interested in looking further at GMM support for AGOS game engine, the quick load and save code must be perfected first. Specifically by examining the load the save segments of scripts in each game, to work out exactly what each line is actually doing. Then mirror those changes exactly (with comments) in the AGOS game engine, to perfect the quick loading and saving code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once the engine has been started and the game is at a safe place to
save/load (as determined by quickLoadOrSave()) the player can save/load
their game using the GMM.
Currently, the save descriptor shown in the listsaves is the filename,
but the actual correct descriptor is correct in the save when saving via
the GMM. The descriptor saved using the GMM can be seen using the original
game save/load menus. The displaying of the correct descriptor can be added
later.
The filenames shown by listsaves is generated from the input target
which can be one of several games. Most of them are just the basename so
the target simon2-cd-win is just simon2.xxx for the savefile, but for
waxworks and elvira2 they differ on whether the platform is dos
or amiga. Since the target does not contain this information I am
currently not differentiating the two, so I defaulted it to generate
names based on the dos version. This can also be changed later. For
amiga waxworks and elvira2 this has the effect that saved games cannot
be loaded/seen using listsaves. They will be correctly saved when saving via
the GMM since that does not use the savefile name generated from the target.
I've tested this with waxworks dos, simon1 dos and simon2 dos.