Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.hnix: Fix build #43824

Merged
merged 1 commit into from Jul 19, 2018
Merged

haskellPackages.hnix: Fix build #43824

merged 1 commit into from Jul 19, 2018

Conversation

infinisil
Copy link
Member

@infinisil infinisil commented Jul 19, 2018 •
edited

Motivation for this change

hnix was broken, closes #43491

And see comment in the change, which haskell-nix/hnix#329

Ping @jwiegley @Profpatsch @peti @manveru @domenkozar

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@infinisil infinisil requested a review from peti as a code owner July 19, 2018 17:36
@domenkozar
Copy link
Member

@GrahamcOfBorg build haskellPackages.hnix

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: haskellPackages.hnix

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: haskellPackages.hnix

Partial log (click to expand)

strip is /nix/store/90vmpr41dzsx350k5argycaf693hnl1l-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/84c09v13m1x0l430nv4v84r8xymp7cib-hnix-0.5.1/lib  /nix/store/84c09v13m1x0l430nv4v84r8xymp7cib-hnix-0.5.1/bin
patching script interpreter paths in /nix/store/84c09v13m1x0l430nv4v84r8xymp7cib-hnix-0.5.1
checking for references to /build in /nix/store/84c09v13m1x0l430nv4v84r8xymp7cib-hnix-0.5.1...
wrong ELF type
shrinking RPATHs of ELF executables and libraries in /nix/store/8k0fbd5cpq55pmflgvvrmkjjp6li81lf-hnix-0.5.1-doc
strip is /nix/store/90vmpr41dzsx350k5argycaf693hnl1l-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/8k0fbd5cpq55pmflgvvrmkjjp6li81lf-hnix-0.5.1-doc
checking for references to /build in /nix/store/8k0fbd5cpq55pmflgvvrmkjjp6li81lf-hnix-0.5.1-doc...
/nix/store/84c09v13m1x0l430nv4v84r8xymp7cib-hnix-0.5.1

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: haskellPackages.hnix

Partial log (click to expand)

/nix/store/834gbkb49607jbvg7fl58snfxdczi7q2-hnix-0.5.1/lib/ghc-8.4.3/x86_64-osx-ghc-8.4.3/libHShnix-0.5.1-I604HEhUhDzJHCyiYmWurP-ghc8.4.3.dylib: fixing dylib
/nix/store/834gbkb49607jbvg7fl58snfxdczi7q2-hnix-0.5.1/lib/ghc-8.4.3/x86_64-osx-ghc-8.4.3/libHShnix-0.5.1-I604HEhUhDzJHCyiYmWurP-ghc8.4.3.dylib: fixing dylib
/nix/store/834gbkb49607jbvg7fl58snfxdczi7q2-hnix-0.5.1/lib/ghc-8.4.3/x86_64-osx-ghc-8.4.3/libHShnix-0.5.1-I604HEhUhDzJHCyiYmWurP-ghc8.4.3.dylib: fixing dylib
/nix/store/834gbkb49607jbvg7fl58snfxdczi7q2-hnix-0.5.1/lib/ghc-8.4.3/x86_64-osx-ghc-8.4.3/libHShnix-0.5.1-I604HEhUhDzJHCyiYmWurP-ghc8.4.3.dylib: fixing dylib
/nix/store/834gbkb49607jbvg7fl58snfxdczi7q2-hnix-0.5.1/lib/ghc-8.4.3/x86_64-osx-ghc-8.4.3/libHShnix-0.5.1-I604HEhUhDzJHCyiYmWurP-ghc8.4.3.dylib: fixing dylib
/nix/store/834gbkb49607jbvg7fl58snfxdczi7q2-hnix-0.5.1/lib/ghc-8.4.3/x86_64-osx-ghc-8.4.3/libHShnix-0.5.1-I604HEhUhDzJHCyiYmWurP-ghc8.4.3.dylib: fixing dylib
/nix/store/834gbkb49607jbvg7fl58snfxdczi7q2-hnix-0.5.1/lib/ghc-8.4.3/x86_64-osx-ghc-8.4.3/libHShnix-0.5.1-I604HEhUhDzJHCyiYmWurP-ghc8.4.3.dylib: fixing dylib
strip is /nix/store/8axizw5mf6dx7wip65nbkyrmlkhmjhc5-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/m9pmnfxhy493rv8g49n8z8wkylnnjm0f-hnix-0.5.1-doc
/nix/store/834gbkb49607jbvg7fl58snfxdczi7q2-hnix-0.5.1

@domenkozar domenkozar merged commit 59159f9 into NixOS:master Jul 19, 2018
@infinisil infinisil deleted the fix/hnix branch July 19, 2018 18:29
jwiegley
jwiegley reviewed Jul 19, 2018
View reviewed changes
pkgs/development/haskell-modules/configuration-common.nix
hnix = (overrideCabal super.hnix (old: {
# dontCheck: Can be removed once https://github.com/haskell-nix/hnix/commit/471712f is in (5.2 probably)
# This is due to GenList having been removed from generic-random in 1.2.0.0
# doJailbreak: Can be removed once https://github.com/haskell-nix/hnix/pull/329 is in (5.2 probably)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been merged.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! Now just needs a new hackage release and a nixpkgs lts update to remove the hacks :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do this once we have the Travis builds for hnix working again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwiegley jwiegley jwiegley left review comments

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dhall-to-nix is broken
4 participants
@infinisil @domenkozar @GrahamcOfBorg @jwiegley