Add recurse overlay #43832
Closed
Add recurse overlay #43832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an overlay that will add the recurse attribute for nix-env & hydra. It can now be disabled with the config.dontRecurse option.
These either had no effect or didn’t make sense in the context.
matthewbauer
requested review from
Ericson2314,
LnL7,
Mic92,
nbp and
ttuegel
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This moves all of the
recurseIntoAttrscalls to the recurse.nix file. That overlay is applied after allPackages UNLESS you have config.dontRecurse set to true. This can significantly speed upnix-env -qaevaluation at the cost of less packages listed.$ time nix-env -qa -f https://github.com/NixOS/nixpkgs/archive/master.tar.gz >/dev/null
8.319 secs
$ time nix-env -qa -f https://github.com/matthewbauer/nixpkgs/archive/recurse-overlay.tar.gz --arg config '{dontRecurse=true;}' >/dev/null
3.805 secs
$ nix-env -qa -f https://github.com/NixOS/nixpkgs/archive/master.tar.gz | wc -l
16284
$ nix-env -qa -f https://github.com/matthewbauer/nixpkgs/archive/recurse-overlay.tar.gz --arg config '{dontRecurse=true;}' | wc -l
7975