pipenv: 2018.5.18 -> 2018.7.1 #43823
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FRidh
requested changes
Jul 19, 2018
| }; | ||
|
|
||
| propagatedBuildInputs = [ six attrs arpeggio ]; | ||
| buildInputs = [ pytest hypothesis pretend ]; |
There was a problem hiding this comment.
checkInputs for test dependencies
domenkozar
force-pushed
the
pipenv-2018.7.1
branch
from
a2e5cf8
to
f6e57be
Compare
|
@FRidh should this go to staging? |
FRidh
requested changes
Jul 19, 2018
| pname = "hypothesis"; | ||
|
|
||
| # Upstream prefers github tarballs | ||
| src = fetchFromGitHub { |
There was a problem hiding this comment.
this should remain fetchFromGitHub because upstream doesn't include tests in their tarball
There was a problem hiding this comment.
They have completely reworked their testing infrastructure (there' no more setup.py even) so I haven't bothered reverse engineering it.
| }; | ||
|
|
||
| checkInputs = [ pytest pytest_xdist flaky mock ]; | ||
| propagatedBuildInputs = [ attrs coverage ] ++ lib.optional (!isPy3k) [ enum34 ]; | ||
|
|
||
| inherit doCheck; | ||
|
|
||
| # https://github.com/DRMacIver/hypothesis/issues/300 | ||
| checkPhase = '' |
There was a problem hiding this comment.
This likely should be kept as well, unless they've changed their tox.ini to reduce the test scope.
|
Yep, staging as well. |
|
Success on x86_64-darwin (full log) Attempted: pipenv Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: pipenv Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: pipenv Partial log (click to expand)
|
|
Seems they redid their repo layout. It is now in a subfolder, so you could use |
domenkozar
force-pushed
the
pipenv-2018.7.1
branch
from
f6e57be
to
01ddbff
Compare
|
@FRidh switched to staging-next and fixed hypothesis to use sourceRoot subfolder. |
|
@domenkozar this goes via |
(cherry picked from commit 01ddbffce6b371741c471db6e5dc71cb6addc4a8) Signed-off-by: Domen Kožar <domen@dev.si>
domenkozar
force-pushed
the
pipenv-2018.7.1
branch
from
01ddbff
to
e06ecf6
Compare
|
@FRidh done |
|
Failure on x86_64-darwin (full log) Attempted: pipenv Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: pipenv Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: pipenv Partial log (click to expand)
|
|
Included in #43972 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
Checked that pipenv works.
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)