Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firefox-bin: fix for broken icons due to broken symlink #45019

Merged
merged 1 commit into from Aug 14, 2018
Merged

firefox-bin: fix for broken icons due to broken symlink #45019

merged 1 commit into from Aug 14, 2018

Conversation

garbas
Copy link
Member

@garbas garbas commented Aug 14, 2018 •
edited

Motivation for this change

fixes #44893

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 merged commit 9cbc736 into NixOS:release-18.03 Aug 14, 2018
@garbas garbas deleted the fix-firefox-bin-on-18.03 branch August 14, 2018 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@garbas @Mic92 @GrahamcOfBorg