Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.javalib: 2.3.4 -> 2.3.5 #45016

Merged
merged 1 commit into from Aug 14, 2018
Merged

ocamlPackages.javalib: 2.3.4 -> 2.3.5 #45016

merged 1 commit into from Aug 14, 2018

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Aug 14, 2018

Motivation for this change

Compatibility with OCaml ≥ 4.06

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@vbgl
Copy link
Contributor Author

vbgl commented Aug 14, 2018

@GrahamcOfBorg build ocamlPackages.sawja

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ocamlPackages.sawja

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/004f9vj6pswamg4qbn20bvk5k13wh7iq-ocaml4.05.0-sawja-1.5.3
shrinking /nix/store/004f9vj6pswamg4qbn20bvk5k13wh7iq-ocaml4.05.0-sawja-1.5.3/lib/ocaml/4.05.0/site-lib/sawja/sawja_pack.o
wrong ELF type
strip is /nix/store/gpc2wld1s0c6qzx9326cwn1wcx29xzsj-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/004f9vj6pswamg4qbn20bvk5k13wh7iq-ocaml4.05.0-sawja-1.5.3/lib
patching script interpreter paths in /nix/store/004f9vj6pswamg4qbn20bvk5k13wh7iq-ocaml4.05.0-sawja-1.5.3
checking for references to /build in /nix/store/004f9vj6pswamg4qbn20bvk5k13wh7iq-ocaml4.05.0-sawja-1.5.3...
wrong ELF type
/nix/store/004f9vj6pswamg4qbn20bvk5k13wh7iq-ocaml4.05.0-sawja-1.5.3

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: ocamlPackages.sawja

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/7x0v5nn7lly7iwj6vxbgjx21glg21yqz-ocaml4.06.1-sawja-1.5.3
shrinking /nix/store/7x0v5nn7lly7iwj6vxbgjx21glg21yqz-ocaml4.06.1-sawja-1.5.3/lib/ocaml/4.06.1/site-lib/sawja/sawja_pack.o
wrong ELF type
strip is /nix/store/ah0va6j4cnwj9nx4j6rwcfc8nh785jwm-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/7x0v5nn7lly7iwj6vxbgjx21glg21yqz-ocaml4.06.1-sawja-1.5.3/lib
patching script interpreter paths in /nix/store/7x0v5nn7lly7iwj6vxbgjx21glg21yqz-ocaml4.06.1-sawja-1.5.3
checking for references to /build in /nix/store/7x0v5nn7lly7iwj6vxbgjx21glg21yqz-ocaml4.06.1-sawja-1.5.3...
wrong ELF type
/nix/store/7x0v5nn7lly7iwj6vxbgjx21glg21yqz-ocaml4.06.1-sawja-1.5.3

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: ocamlPackages.sawja

Partial log (click to expand)

Installed /nix/store/ivhcjmm2b19wmi4pdipygn3ar8cwii2x-ocaml4.05.0-sawja-1.5.3/lib/ocaml/4.05.0/site-lib/sawja/iter.mli
Installed /nix/store/ivhcjmm2b19wmi4pdipygn3ar8cwii2x-ocaml4.05.0-sawja-1.5.3/lib/ocaml/4.05.0/site-lib/sawja/sawja.cmxa
Installed /nix/store/ivhcjmm2b19wmi4pdipygn3ar8cwii2x-ocaml4.05.0-sawja-1.5.3/lib/ocaml/4.05.0/site-lib/sawja/sawja.cma
Installed /nix/store/ivhcjmm2b19wmi4pdipygn3ar8cwii2x-ocaml4.05.0-sawja-1.5.3/lib/ocaml/4.05.0/site-lib/sawja/META
make[1]: Leaving directory '/private/tmp/nix-build-ocaml4.05.0-sawja-1.5.3.drv-0/sawja-1.5.3/src'
post-installation fixup
strip is /nix/store/251fvx4mx9q4zarbca5cciasmn66p668-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/ivhcjmm2b19wmi4pdipygn3ar8cwii2x-ocaml4.05.0-sawja-1.5.3/lib
patching script interpreter paths in /nix/store/ivhcjmm2b19wmi4pdipygn3ar8cwii2x-ocaml4.05.0-sawja-1.5.3
/nix/store/ivhcjmm2b19wmi4pdipygn3ar8cwii2x-ocaml4.05.0-sawja-1.5.3

@xeji xeji merged commit be989c7 into NixOS:master Aug 14, 2018
@vbgl vbgl deleted the ocaml-javalib-2.3.5 branch August 14, 2018 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: ocaml 8.has: package (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vbgl @GrahamcOfBorg @xeji