Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xsecurelock: git-2018-07-10 -> 1.0 #44998

Merged
merged 1 commit into from Aug 14, 2018
Merged

xsecurelock: git-2018-07-10 -> 1.0 #44998

merged 1 commit into from Aug 14, 2018

Conversation

bchallenor
Copy link
Contributor

@bchallenor bchallenor commented Aug 13, 2018 •
edited

Motivation for this change

v1.0 released

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@fpletz

worldofpeace
worldofpeace reviewed Aug 13, 2018
View reviewed changes
pkgs/tools/X11/xsecurelock/default.nix Outdated

src = fetchFromGitHub {
owner = "google";
repo = "xsecurelock";
rev = "0fa0d7dd87a4cc4bdb402323f95c3fcacc6f5049";
sha256 = "071b3gslszql1mgabs53r82jgbk9mn263m5v6adskfxbkamks8g0";
rev = "c11afd6688518eaa657f35e74316c4ed741e8bf9";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about rev = "v${version}";?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we happy with tags given that they are mutable? I do prefer the readability of the tag though, and I guess immutability is enforced by the sha256 too.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We prefer to use version tags by default for easier updating and better readability. If we experience problems with moving tags for a particular package we switch it to git revisions later.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted. Updated the commit accordingly.

@xeji
Copy link
Contributor

xeji commented Aug 13, 2018

@GrahamcOfBorg build xsecurelock

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: xsecurelock

Partial log (click to expand)

shrinking /nix/store/nhfi3dni5rzxvid5sp5h7c624h4nm6jk-xsecurelock-1.0/bin/xsecurelock
strip is /nix/store/gpc2wld1s0c6qzx9326cwn1wcx29xzsj-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/nhfi3dni5rzxvid5sp5h7c624h4nm6jk-xsecurelock-1.0/libexec  /nix/store/nhfi3dni5rzxvid5sp5h7c624h4nm6jk-xsecurelock-1.0/bin
patching script interpreter paths in /nix/store/nhfi3dni5rzxvid5sp5h7c624h4nm6jk-xsecurelock-1.0
/nix/store/nhfi3dni5rzxvid5sp5h7c624h4nm6jk-xsecurelock-1.0/libexec/xsecurelock/auth_pamtester: interpreter directive changed from "/bin/sh" to "/nix/store/56nrxy58wbhvs2sy3rir1jqa68p0kkm5-bash-4.4-p23/bin/sh"
/nix/store/nhfi3dni5rzxvid5sp5h7c624h4nm6jk-xsecurelock-1.0/libexec/xsecurelock/auth_htpasswd: interpreter directive changed from "/bin/sh" to "/nix/store/56nrxy58wbhvs2sy3rir1jqa68p0kkm5-bash-4.4-p23/bin/sh"
/nix/store/nhfi3dni5rzxvid5sp5h7c624h4nm6jk-xsecurelock-1.0/libexec/xsecurelock/saver_blank: interpreter directive changed from "/bin/sh" to "/nix/store/56nrxy58wbhvs2sy3rir1jqa68p0kkm5-bash-4.4-p23/bin/sh"
/nix/store/nhfi3dni5rzxvid5sp5h7c624h4nm6jk-xsecurelock-1.0/libexec/xsecurelock/saver_xscreensaver: interpreter directive changed from "/bin/sh" to "/nix/store/56nrxy58wbhvs2sy3rir1jqa68p0kkm5-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/nhfi3dni5rzxvid5sp5h7c624h4nm6jk-xsecurelock-1.0...
/nix/store/nhfi3dni5rzxvid5sp5h7c624h4nm6jk-xsecurelock-1.0

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: xsecurelock

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: xsecurelock

Partial log (click to expand)

shrinking /nix/store/3967crb4g6shmyzn782ynpdqwdb36sr8-xsecurelock-1.0/bin/xsecurelock
strip is /nix/store/ah0va6j4cnwj9nx4j6rwcfc8nh785jwm-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/3967crb4g6shmyzn782ynpdqwdb36sr8-xsecurelock-1.0/libexec  /nix/store/3967crb4g6shmyzn782ynpdqwdb36sr8-xsecurelock-1.0/bin
patching script interpreter paths in /nix/store/3967crb4g6shmyzn782ynpdqwdb36sr8-xsecurelock-1.0
/nix/store/3967crb4g6shmyzn782ynpdqwdb36sr8-xsecurelock-1.0/libexec/xsecurelock/saver_xscreensaver: interpreter directive changed from "/bin/sh" to "/nix/store/7q3ayirslrcva28wava6zpjcflcz1h3b-bash-4.4-p23/bin/sh"
/nix/store/3967crb4g6shmyzn782ynpdqwdb36sr8-xsecurelock-1.0/libexec/xsecurelock/auth_pamtester: interpreter directive changed from "/bin/sh" to "/nix/store/7q3ayirslrcva28wava6zpjcflcz1h3b-bash-4.4-p23/bin/sh"
/nix/store/3967crb4g6shmyzn782ynpdqwdb36sr8-xsecurelock-1.0/libexec/xsecurelock/auth_htpasswd: interpreter directive changed from "/bin/sh" to "/nix/store/7q3ayirslrcva28wava6zpjcflcz1h3b-bash-4.4-p23/bin/sh"
/nix/store/3967crb4g6shmyzn782ynpdqwdb36sr8-xsecurelock-1.0/libexec/xsecurelock/saver_blank: interpreter directive changed from "/bin/sh" to "/nix/store/7q3ayirslrcva28wava6zpjcflcz1h3b-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/3967crb4g6shmyzn782ynpdqwdb36sr8-xsecurelock-1.0...
/nix/store/3967crb4g6shmyzn782ynpdqwdb36sr8-xsecurelock-1.0

@xeji
Copy link
Contributor

xeji commented Aug 13, 2018

@GrahamcOfBorg build xsecurelock

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: xsecurelock

Partial log (click to expand)

/nix/store/nhfi3dni5rzxvid5sp5h7c624h4nm6jk-xsecurelock-1.0

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: xsecurelock

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: xsecurelock

Partial log (click to expand)

/nix/store/3967crb4g6shmyzn782ynpdqwdb36sr8-xsecurelock-1.0

@fpletz fpletz merged commit d9e6d14 into NixOS:master Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@xeji xeji xeji approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@bchallenor @xeji @GrahamcOfBorg @worldofpeace @fpletz @Janik-Haag