Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ratpoints: 2.1.3 -> 2.1.3.p4; add darwin support #45009

Merged
merged 1 commit into from Aug 15, 2018
Merged

ratpoints: 2.1.3 -> 2.1.3.p4; add darwin support #45009

merged 1 commit into from Aug 15, 2018

Conversation

jbaum98
Copy link
Contributor

@jbaum98 jbaum98 commented Aug 14, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added the 6.topic: darwin Running or building packages on Darwin label Aug 14, 2018
@adisbladis
Copy link
Member

@GrahamcOfBorg build ratpoints

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ratpoints

Partial log (click to expand)

cp libratpoints.a /nix/store/i601z28apwjla4453cgkak3n9g0dljnv-ratpoints-2.1.3.p4/lib/
chmod 644 /nix/store/i601z28apwjla4453cgkak3n9g0dljnv-ratpoints-2.1.3.p4/lib/libratpoints.a
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/i601z28apwjla4453cgkak3n9g0dljnv-ratpoints-2.1.3.p4
shrinking /nix/store/i601z28apwjla4453cgkak3n9g0dljnv-ratpoints-2.1.3.p4/bin/ratpoints
strip is /nix/store/gpc2wld1s0c6qzx9326cwn1wcx29xzsj-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/i601z28apwjla4453cgkak3n9g0dljnv-ratpoints-2.1.3.p4/lib  /nix/store/i601z28apwjla4453cgkak3n9g0dljnv-ratpoints-2.1.3.p4/bin
patching script interpreter paths in /nix/store/i601z28apwjla4453cgkak3n9g0dljnv-ratpoints-2.1.3.p4
checking for references to /build in /nix/store/i601z28apwjla4453cgkak3n9g0dljnv-ratpoints-2.1.3.p4...
/nix/store/i601z28apwjla4453cgkak3n9g0dljnv-ratpoints-2.1.3.p4

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: ratpoints

Partial log (click to expand)

cp libratpoints.a /nix/store/jds25d2ngbrwjz65qli884jhidn64byc-ratpoints-2.1.3.p4/lib/
chmod 644 /nix/store/jds25d2ngbrwjz65qli884jhidn64byc-ratpoints-2.1.3.p4/lib/libratpoints.a
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/jds25d2ngbrwjz65qli884jhidn64byc-ratpoints-2.1.3.p4
shrinking /nix/store/jds25d2ngbrwjz65qli884jhidn64byc-ratpoints-2.1.3.p4/bin/ratpoints
strip is /nix/store/ah0va6j4cnwj9nx4j6rwcfc8nh785jwm-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/jds25d2ngbrwjz65qli884jhidn64byc-ratpoints-2.1.3.p4/lib  /nix/store/jds25d2ngbrwjz65qli884jhidn64byc-ratpoints-2.1.3.p4/bin
patching script interpreter paths in /nix/store/jds25d2ngbrwjz65qli884jhidn64byc-ratpoints-2.1.3.p4
checking for references to /build in /nix/store/jds25d2ngbrwjz65qli884jhidn64byc-ratpoints-2.1.3.p4...
/nix/store/jds25d2ngbrwjz65qli884jhidn64byc-ratpoints-2.1.3.p4

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: ratpoints

Partial log (click to expand)

chmod 755 /nix/store/2bknz6bf778rgf7gx01sng5r3v3ki0rr-ratpoints-2.1.3.p4/bin/ratpoints
cp ratpoints.h /nix/store/2bknz6bf778rgf7gx01sng5r3v3ki0rr-ratpoints-2.1.3.p4/include/
chmod 644 /nix/store/2bknz6bf778rgf7gx01sng5r3v3ki0rr-ratpoints-2.1.3.p4/include/ratpoints.h
cp libratpoints.a /nix/store/2bknz6bf778rgf7gx01sng5r3v3ki0rr-ratpoints-2.1.3.p4/lib/
chmod 644 /nix/store/2bknz6bf778rgf7gx01sng5r3v3ki0rr-ratpoints-2.1.3.p4/lib/libratpoints.a
post-installation fixup
strip is /nix/store/251fvx4mx9q4zarbca5cciasmn66p668-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/2bknz6bf778rgf7gx01sng5r3v3ki0rr-ratpoints-2.1.3.p4/lib  /nix/store/2bknz6bf778rgf7gx01sng5r3v3ki0rr-ratpoints-2.1.3.p4/bin
patching script interpreter paths in /nix/store/2bknz6bf778rgf7gx01sng5r3v3ki0rr-ratpoints-2.1.3.p4
/nix/store/2bknz6bf778rgf7gx01sng5r3v3ki0rr-ratpoints-2.1.3.p4

Mic92
Mic92 reviewed Aug 14, 2018
View reviewed changes
pkgs/applications/science/math/ratpoints/default.nix Outdated

patches = [
(fetchpatch {
url = "https://git.sagemath.org/sage.git/plain/build/pkgs/ratpoints/patches/sturm_and_rp_private.patch";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can your refer to a specific commit? Otherwise an update of the patch will break the hash.

@mpickering
Copy link
Contributor

Looks good to me now the issue @Mic92 pointed out has been fixed.

@adisbladis
Copy link
Member

@GrahamcOfBorg build ratpoints

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: ratpoints

Partial log (click to expand)

cp libratpoints.a /nix/store/xx5kbxdh3gql8bxdagfrs2nbl4nk85xw-ratpoints-2.1.3.p4/lib/
chmod 644 /nix/store/xx5kbxdh3gql8bxdagfrs2nbl4nk85xw-ratpoints-2.1.3.p4/lib/libratpoints.a
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/xx5kbxdh3gql8bxdagfrs2nbl4nk85xw-ratpoints-2.1.3.p4
shrinking /nix/store/xx5kbxdh3gql8bxdagfrs2nbl4nk85xw-ratpoints-2.1.3.p4/bin/ratpoints
strip is /nix/store/ah0va6j4cnwj9nx4j6rwcfc8nh785jwm-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/xx5kbxdh3gql8bxdagfrs2nbl4nk85xw-ratpoints-2.1.3.p4/lib  /nix/store/xx5kbxdh3gql8bxdagfrs2nbl4nk85xw-ratpoints-2.1.3.p4/bin
patching script interpreter paths in /nix/store/xx5kbxdh3gql8bxdagfrs2nbl4nk85xw-ratpoints-2.1.3.p4
checking for references to /build in /nix/store/xx5kbxdh3gql8bxdagfrs2nbl4nk85xw-ratpoints-2.1.3.p4...
/nix/store/xx5kbxdh3gql8bxdagfrs2nbl4nk85xw-ratpoints-2.1.3.p4

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ratpoints

Partial log (click to expand)

cp libratpoints.a /nix/store/wm43gryxzxd3wdc7xvkbxk1f8lda4j8r-ratpoints-2.1.3.p4/lib/
chmod 644 /nix/store/wm43gryxzxd3wdc7xvkbxk1f8lda4j8r-ratpoints-2.1.3.p4/lib/libratpoints.a
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/wm43gryxzxd3wdc7xvkbxk1f8lda4j8r-ratpoints-2.1.3.p4
shrinking /nix/store/wm43gryxzxd3wdc7xvkbxk1f8lda4j8r-ratpoints-2.1.3.p4/bin/ratpoints
strip is /nix/store/gpc2wld1s0c6qzx9326cwn1wcx29xzsj-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/wm43gryxzxd3wdc7xvkbxk1f8lda4j8r-ratpoints-2.1.3.p4/lib  /nix/store/wm43gryxzxd3wdc7xvkbxk1f8lda4j8r-ratpoints-2.1.3.p4/bin
patching script interpreter paths in /nix/store/wm43gryxzxd3wdc7xvkbxk1f8lda4j8r-ratpoints-2.1.3.p4
checking for references to /build in /nix/store/wm43gryxzxd3wdc7xvkbxk1f8lda4j8r-ratpoints-2.1.3.p4...
/nix/store/wm43gryxzxd3wdc7xvkbxk1f8lda4j8r-ratpoints-2.1.3.p4

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: ratpoints

Partial log (click to expand)

chmod 755 /nix/store/vxl2l8hcfdvh8xxpid08j1wjag0r6wl8-ratpoints-2.1.3.p4/bin/ratpoints
cp ratpoints.h /nix/store/vxl2l8hcfdvh8xxpid08j1wjag0r6wl8-ratpoints-2.1.3.p4/include/
chmod 644 /nix/store/vxl2l8hcfdvh8xxpid08j1wjag0r6wl8-ratpoints-2.1.3.p4/include/ratpoints.h
cp libratpoints.a /nix/store/vxl2l8hcfdvh8xxpid08j1wjag0r6wl8-ratpoints-2.1.3.p4/lib/
chmod 644 /nix/store/vxl2l8hcfdvh8xxpid08j1wjag0r6wl8-ratpoints-2.1.3.p4/lib/libratpoints.a
post-installation fixup
strip is /nix/store/251fvx4mx9q4zarbca5cciasmn66p668-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/vxl2l8hcfdvh8xxpid08j1wjag0r6wl8-ratpoints-2.1.3.p4/lib  /nix/store/vxl2l8hcfdvh8xxpid08j1wjag0r6wl8-ratpoints-2.1.3.p4/bin
patching script interpreter paths in /nix/store/vxl2l8hcfdvh8xxpid08j1wjag0r6wl8-ratpoints-2.1.3.p4
/nix/store/vxl2l8hcfdvh8xxpid08j1wjag0r6wl8-ratpoints-2.1.3.p4

@adisbladis adisbladis merged commit 2937e73 into NixOS:master Aug 15, 2018
@adisbladis
Copy link
Member

Thanks :)

@jbaum98 jbaum98 deleted the ratpoints-darwin branch August 15, 2018 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jbaum98 @adisbladis @GrahamcOfBorg @mpickering @Mic92