New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding new package: Wavebox #45021
Adding new package: Wavebox #45021
Conversation
meta = with stdenv.lib; { | ||
description = "Wavebox messaging application"; | ||
homepage = https://wavebox.io; | ||
license = licenses.free; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be licenses.mpl20
runtimeDependencies = [ udev.lib libnotify ]; | ||
|
||
unpackPhase = '' | ||
tar xzf $src |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default unpackPhase should be able to unpack a tarball as well
gtk2 gtk3 atk glib pango gdk_pixbuf cairo freetype fontconfig dbus | ||
gnome3.gconf nss nspr alsaLib cups expat stdenv.cc.cc | ||
]; | ||
runtimeDependencies = [ udev.lib libnotify ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The indentation is off here
2a14100
to
62f643c
Compare
Thanks, @tilpner; commit amended with fixes. |
homepage = https://wavebox.io; | ||
license = licenses.mpl20; | ||
platforms = ["x86_64-linux"]; | ||
hydraPlatforms = []; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to maintain this? https://nixos.wiki/wiki/Nixpkgs#Becoming_a_Nixpkgs_maintainer
libXrender libX11 libXtst libXScrnSaver | ||
]) ++ [ | ||
gtk2 gtk3 atk glib pango gdk_pixbuf cairo freetype fontconfig dbus | ||
gnome3.gconf nss nspr alsaLib cups expat stdenv.cc.cc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gconf is missing.
@Mic92 Resolved those issues. Would you like the commits squashed? |
license = licenses.mpl20; | ||
maintainers = with maintainers; [ rawkode ]; | ||
platforms = ["x86_64-linux"]; | ||
hydraPlatforms = []; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you want to exclude this from Hydra builds? This will force local building for all users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm new to making NixOS packages. I was taking inspiration from:
https://github.com/NixOS/nixpkgs/blob/master/pkgs/applications/networking/instant-messengers/franz/default.nix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, it actually makes some sense for this package, because it's a binary release and there's no real building to do - just install everything from the tarball.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted. Thanks, @xeji
Hey man im not too familiar with all this . I need help . my cell phone was hacked . i am locked out of all my accounts . |
binary did not exists, reduced needed libraries, fixed missing gconf
Motivation for this change
Closes #43880
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)