Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new package: Wavebox #45021

Merged
merged 5 commits into from Aug 15, 2018
Merged

Adding new package: Wavebox #45021

merged 5 commits into from Aug 15, 2018

Conversation

rawkode
Copy link
Member

@rawkode rawkode commented Aug 14, 2018

Motivation for this change

Closes #43880

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

meta = with stdenv.lib; {
description = "Wavebox messaging application";
homepage = https://wavebox.io;
license = licenses.free;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be licenses.mpl20

runtimeDependencies = [ udev.lib libnotify ];

unpackPhase = ''
tar xzf $src
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default unpackPhase should be able to unpack a tarball as well

gtk2 gtk3 atk glib pango gdk_pixbuf cairo freetype fontconfig dbus
gnome3.gconf nss nspr alsaLib cups expat stdenv.cc.cc
];
runtimeDependencies = [ udev.lib libnotify ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation is off here

@rawkode
Copy link
Member Author

rawkode commented Aug 14, 2018

Thanks, @tilpner; commit amended with fixes.

homepage = https://wavebox.io;
license = licenses.mpl20;
platforms = ["x86_64-linux"];
hydraPlatforms = [];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libXrender libX11 libXtst libXScrnSaver
]) ++ [
gtk2 gtk3 atk glib pango gdk_pixbuf cairo freetype fontconfig dbus
gnome3.gconf nss nspr alsaLib cups expat stdenv.cc.cc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gconf is missing.

@rawkode
Copy link
Member Author

rawkode commented Aug 14, 2018

@Mic92 Resolved those issues. Would you like the commits squashed?

license = licenses.mpl20;
maintainers = with maintainers; [ rawkode ];
platforms = ["x86_64-linux"];
hydraPlatforms = [];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you want to exclude this from Hydra builds? This will force local building for all users.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, it actually makes some sense for this package, because it's a binary release and there's no real building to do - just install everything from the tarball.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted. Thanks, @xeji

@jokerjack85
Copy link

Hey man im not too familiar with all this . I need help . my cell phone was hacked . i am locked out of all my accounts .

binary did not exists, reduced needed libraries, fixed missing gconf
@Mic92 Mic92 merged commit 27ddcc5 into NixOS:master Aug 15, 2018
@rawkode rawkode deleted the new-package/wavebox branch August 17, 2018 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package Request: Wavebox
7 participants