Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tachyon: Add darwin support #45006

Merged
merged 1 commit into from Aug 14, 2018
Merged

tachyon: Add darwin support #45006

merged 1 commit into from Aug 14, 2018

Conversation

jbaum98
Copy link
Contributor

@jbaum98 jbaum98 commented Aug 14, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@kalbasit
Copy link
Member

@GrahamcOfBorg build tachyon

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tachyon

Partial log (click to expand)

  /nix/store/cqcjk5v1a21shigqyx4a391i14snbaxq-glibc-2.27
  /nix/store/f7k0b9jkpdwwc45gizwxmwwvdbfs9mfk-zlib-1.2.11
  /nix/store/p9mf1sxvmy2z733qmac9f3h2r6fq58rl-libpng-apng-1.6.34
  /nix/store/zx8ibzs0hydwkqrz7nb9cx0199rf410x-libjpeg-turbo-1.5.3
copying path '/nix/store/cqcjk5v1a21shigqyx4a391i14snbaxq-glibc-2.27' from 'https://cache.nixos.org'...
copying path '/nix/store/zx8ibzs0hydwkqrz7nb9cx0199rf410x-libjpeg-turbo-1.5.3' from 'https://cache.nixos.org'...
copying path '/nix/store/f7k0b9jkpdwwc45gizwxmwwvdbfs9mfk-zlib-1.2.11' from 'https://cache.nixos.org'...
copying path '/nix/store/p9mf1sxvmy2z733qmac9f3h2r6fq58rl-libpng-apng-1.6.34' from 'https://cache.nixos.org'...
copying path '/nix/store/69kp0mffxiazfk0h3r9r6112rynlgvn7-tachyon-0.99b2' from 'https://cache.nixos.org'...
/nix/store/69kp0mffxiazfk0h3r9r6112rynlgvn7-tachyon-0.99b2

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tachyon

Partial log (click to expand)

these paths will be fetched (1.62 MiB download, 9.72 MiB unpacked):
  /nix/store/39jy92jcr72i7jljlzwqmpxbdbvxpblx-tachyon-0.99b2
copying path '/nix/store/39jy92jcr72i7jljlzwqmpxbdbvxpblx-tachyon-0.99b2' from 'https://cache.nixos.org'...
/nix/store/39jy92jcr72i7jljlzwqmpxbdbvxpblx-tachyon-0.99b2

@kalbasit kalbasit mentioned this pull request Aug 14, 2018
Merged
@adisbladis
Copy link
Member

@GrahamcOfBorg build tachyon

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tachyon

Partial log (click to expand)

/nix/store/69kp0mffxiazfk0h3r9r6112rynlgvn7-tachyon-0.99b2

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tachyon

Partial log (click to expand)

these paths will be fetched (1.95 MiB download, 11.24 MiB unpacked):
  /nix/store/39jy92jcr72i7jljlzwqmpxbdbvxpblx-tachyon-0.99b2
  /nix/store/hj5w4fibz00w5vrlbgf274nd6i5r28j0-libpng-apng-1.6.34
  /nix/store/nkpciwh3zkjvl8nm1a9hx3zy2vz7z4qn-zlib-1.2.11
  /nix/store/w81fbb52njyisqly6s80qa3mxv790pg6-libjpeg-turbo-1.5.3
copying path '/nix/store/w81fbb52njyisqly6s80qa3mxv790pg6-libjpeg-turbo-1.5.3' from 'https://cache.nixos.org'...
copying path '/nix/store/nkpciwh3zkjvl8nm1a9hx3zy2vz7z4qn-zlib-1.2.11' from 'https://cache.nixos.org'...
copying path '/nix/store/hj5w4fibz00w5vrlbgf274nd6i5r28j0-libpng-apng-1.6.34' from 'https://cache.nixos.org'...
copying path '/nix/store/39jy92jcr72i7jljlzwqmpxbdbvxpblx-tachyon-0.99b2' from 'https://cache.nixos.org'...
/nix/store/39jy92jcr72i7jljlzwqmpxbdbvxpblx-tachyon-0.99b2

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: tachyon

Partial log (click to expand)

Build Complete
make[1]: Leaving directory '/private/tmp/nix-build-tachyon-0.99b2.drv-0/tachyon/unix'
installing
post-installation fixup
strip is /nix/store/251fvx4mx9q4zarbca5cciasmn66p668-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/x6vydz05z0xfiv12n6n7gcamsq0krnqd-tachyon-0.99b2/lib  /nix/store/x6vydz05z0xfiv12n6n7gcamsq0krnqd-tachyon-0.99b2/bin
patching script interpreter paths in /nix/store/x6vydz05z0xfiv12n6n7gcamsq0krnqd-tachyon-0.99b2
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
/nix/store/x6vydz05z0xfiv12n6n7gcamsq0krnqd-tachyon-0.99b2

@adisbladis adisbladis merged commit 3878342 into NixOS:master Aug 14, 2018
@adisbladis
Copy link
Member

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jbaum98 @kalbasit @GrahamcOfBorg @adisbladis