New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
symmetrica: Add darwin support #45011
Conversation
@@ -34,13 +29,34 @@ stdenv.mkDerivation rec { | |||
url = "https://git.sagemath.org/sage.git/plain/build/pkgs/symmetrica/patches/int32.patch?id=07d6c37d18811e2b377a9689790a7c5e24da16ba"; | |||
sha256 = "0p33c85ck4kd453z687ni4bdcqr1pqx2756j7aq11bf63vjz4cyz"; | |||
}) | |||
|
|||
(fetchpatch { | |||
url = "https://git.sagemath.org/sage.git/plain/build/pkgs/symmetrica/patches/return_values.patch"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use a commit instead of master to load this patch to avoid breakages if the source gets an update?
7d0f083
to
8ae47fa
Compare
@GrahamcOfBorg build symmetrica |
Success on x86_64-linux (full log) Attempted: symmetrica Partial log (click to expand)
|
Success on x86_64-darwin (full log) Attempted: symmetrica Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: symmetrica Partial log (click to expand)
|
LGTM. |
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)