Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

symmetrica: Add darwin support #45011

Merged
merged 1 commit into from Aug 15, 2018
Merged

Conversation

jbaum98
Copy link
Contributor

@jbaum98 jbaum98 commented Aug 14, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@@ -34,13 +29,34 @@ stdenv.mkDerivation rec {
url = "https://git.sagemath.org/sage.git/plain/build/pkgs/symmetrica/patches/int32.patch?id=07d6c37d18811e2b377a9689790a7c5e24da16ba";
sha256 = "0p33c85ck4kd453z687ni4bdcqr1pqx2756j7aq11bf63vjz4cyz";
})

(fetchpatch {
url = "https://git.sagemath.org/sage.git/plain/build/pkgs/symmetrica/patches/return_values.patch";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use a commit instead of master to load this patch to avoid breakages if the source gets an update?

@mpickering
Copy link
Contributor

@GrahamcOfBorg build symmetrica

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: symmetrica

Partial log (click to expand)

cc -c -O2 -DFAST -DALLTRUE zyk.c
cc -DALLTRUE -DFAST test.c bar.o bi.o boe.o bruch.o classical.o de.o di.o ff.o galois.o ga.o gra.o hash.o hiccup.o io.o ko.o list.o lo.o ma.o mee.o mem.o mes.o mhe.o mhh.o mhm.o mhp.o mhs.o mmm.o mms.o mod_dg_sbd.o mo.o mpp.o mps.o mse.o msh.o msm.o mss.o muir.o na.o nb.o nc.o nu.o part.o pee.o peh.o pem.o perm.o pes.o phe.o phh.o phm.o phs.o plet.o pme.o pmh.o poly.o ppe.o pph.o ppm.o ppp.o pps.o pr.o pse.o psh.o psm.o pss.o rest.o rh.o sab.o sb.o sc.o sr.o ta.o teh.o tem.o tep.o tes.o the.o thm.o thp.o ths.o tme.o tmh.o tmp.o tms.o tpe.o tph.o tpm.o tps.o tse.o tsh.o tsm.o tsp.o vc.o zo.o zykelind.o zyk.o -o test -lm
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/rldy661g5nvbhipr43676p14c8969xar-symmetrica-2.0
strip is /nix/store/gpc2wld1s0c6qzx9326cwn1wcx29xzsj-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/rldy661g5nvbhipr43676p14c8969xar-symmetrica-2.0/lib
patching script interpreter paths in /nix/store/rldy661g5nvbhipr43676p14c8969xar-symmetrica-2.0
checking for references to /build in /nix/store/rldy661g5nvbhipr43676p14c8969xar-symmetrica-2.0...
/nix/store/rldy661g5nvbhipr43676p14c8969xar-symmetrica-2.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: symmetrica

Partial log (click to expand)

    else if (S_O_K(a) == INTEGER) C_O_K(a,EMPTY);\
    ^
6 warnings generated.
cc -DALLTRUE -DFAST test.c bar.o bi.o boe.o bruch.o classical.o de.o di.o ff.o galois.o ga.o gra.o hash.o hiccup.o io.o ko.o list.o lo.o ma.o mee.o mem.o mes.o mhe.o mhh.o mhm.o mhp.o mhs.o mmm.o mms.o mod_dg_sbd.o mo.o mpp.o mps.o mse.o msh.o msm.o mss.o muir.o na.o nb.o nc.o nu.o part.o pee.o peh.o pem.o perm.o pes.o phe.o phh.o phm.o phs.o plet.o pme.o pmh.o poly.o ppe.o pph.o ppm.o ppp.o pps.o pr.o pse.o psh.o psm.o pss.o rest.o rh.o sab.o sb.o sc.o sr.o ta.o teh.o tem.o tep.o tes.o the.o thm.o thp.o ths.o tme.o tmh.o tmp.o tms.o tpe.o tph.o tpm.o tps.o tse.o tsh.o tsm.o tsp.o vc.o zo.o zykelind.o zyk.o -o test -lm
installing
post-installation fixup
strip is /nix/store/251fvx4mx9q4zarbca5cciasmn66p668-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/2ki45wv0lwnphw870msv9v0kxllmvvxd-symmetrica-2.0/lib
patching script interpreter paths in /nix/store/2ki45wv0lwnphw870msv9v0kxllmvvxd-symmetrica-2.0
/nix/store/2ki45wv0lwnphw870msv9v0kxllmvvxd-symmetrica-2.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: symmetrica

Partial log (click to expand)

     ^~~~~~~~~~~~~~~~~~~
cc -DALLTRUE -DFAST test.c bar.o bi.o boe.o bruch.o classical.o de.o di.o ff.o galois.o ga.o gra.o hash.o hiccup.o io.o ko.o list.o lo.o ma.o mee.o mem.o mes.o mhe.o mhh.o mhm.o mhp.o mhs.o mmm.o mms.o mod_dg_sbd.o mo.o mpp.o mps.o mse.o msh.o msm.o mss.o muir.o na.o nb.o nc.o nu.o part.o pee.o peh.o pem.o perm.o pes.o phe.o phh.o phm.o phs.o plet.o pme.o pmh.o poly.o ppe.o pph.o ppm.o ppp.o pps.o pr.o pse.o psh.o psm.o pss.o rest.o rh.o sab.o sb.o sc.o sr.o ta.o teh.o tem.o tep.o tes.o the.o thm.o thp.o ths.o tme.o tmh.o tmp.o tms.o tpe.o tph.o tpm.o tps.o tse.o tsh.o tsm.o tsp.o vc.o zo.o zykelind.o zyk.o -o test -lm
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/3yqsng5f3c572s14drak8ks5823v51nd-symmetrica-2.0
strip is /nix/store/ah0va6j4cnwj9nx4j6rwcfc8nh785jwm-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/3yqsng5f3c572s14drak8ks5823v51nd-symmetrica-2.0/lib
patching script interpreter paths in /nix/store/3yqsng5f3c572s14drak8ks5823v51nd-symmetrica-2.0
checking for references to /build in /nix/store/3yqsng5f3c572s14drak8ks5823v51nd-symmetrica-2.0...
/nix/store/3yqsng5f3c572s14drak8ks5823v51nd-symmetrica-2.0

@mpickering
Copy link
Contributor

LGTM.

@Mic92 Mic92 merged commit 0ee6d7e into NixOS:master Aug 15, 2018
@jbaum98 jbaum98 deleted the symmetrica-darwin branch August 15, 2018 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants