doc: add darwin installCheckTarget example #44248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamcOfBorg
added
6.topic: darwin
Mic92
reviewed
Jul 31, 2018
doc/platform-notes.xml
Outdated
| The fact that libraries are liked using the absolute paths of their final | ||
| installation target can, even tho the <literal>install_name</literal> like | ||
| mentioned above is set correctly, sometimes cause problems when running | ||
| tests. |
There was a problem hiding this comment.
This sentence has some spelling issues:
Let me rephrase:
Even so libraries are linked using absolute paths and resolved via their <literal>install_name</literal> on darwin, running tests can cause problems.
Mic92
reviewed
Jul 31, 2018
doc/platform-notes.xml
Outdated
| This can usually be solved by running the tests after the | ||
| <varname>installPhase</varname> or alternatively by using | ||
| <varname>DYLD_LIBRARY_PATH</varname>. More information about this variable | ||
| can be found in <command>man dyld</command>. |
There was a problem hiding this comment.
Optional: It seems to be not so common in nixpkgs doc, but docbook also supports linking to manpages: https://github.com/systemd/systemd/blob/master/man/systemd.device.xml#L16
There was a problem hiding this comment.
Ah nice, I was wondering about that but didn't find an example.
LnL7
force-pushed
the
doc-darwin-installcheck
branch
2 times, most recently
from
536daa5
to
423ce9f
Compare
LnL7
force-pushed
the
doc-darwin-installcheck
branch
from
423ce9f
to
61a1b20
Compare
|
@GrahamcOfBorg eval |
This was referenced Aug 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)