pythonPackages.fluent-logger: init at 0.9.3 #44236

ngortheone · 2018-07-30T17:14:10Z

Motivation for this change

Add fluent-logger package to pythonPackages

Things done

Added pypi fluent-logger package to pythonPackages.nix

Tested using sandboxing - Built on platform(s)
- NixOS
- macOS

References:
https://github.com/fluent/fluent-logger-python
https://pypi.org/project/fluent-logger/

dotlambda

Please format your code and commit message according to the contributing guidelines. Also please use the PR template.

dotlambda · 2018-07-30T17:26:36Z

pkgs/development/python-modules/fluent-logger/default.nix

+buildPythonPackage rec {
+    pname = "fluent-logger";
+    version = "0.9.3";
+    name = "${pname}-${version}";


Drop this line.

dotlambda · 2018-07-30T17:26:43Z

pkgs/development/python-modules/fluent-logger/default.nix

+      sha256 = "09vii0iclfq6vhz37xyybksq9m3538hkr7z40sz2dlpf2rkg98mg";
+    };
+    propagatedBuildInputs = [ msgpack ];
+    doCheck = false;


dotlambda · 2018-07-30T17:27:29Z

pkgs/development/python-modules/fluent-logger/default.nix

+    meta = {
+      description = "A structured logger for Fluentd (Python)";
+      homepage = "https://github.com/fluent/fluent-logger-python";
+    };


license is missing

ngortheone · 2018-07-30T17:36:02Z

@dotlambda thanks for prompt review. Can you show me where PR template is?

dotlambda · 2018-07-30T17:40:05Z

It appears when you make a PR. You can also find it here: https://raw.githubusercontent.com/NixOS/nixpkgs/master/.github/PULL_REQUEST_TEMPLATE.md
It's not that important now but you'd have found a link to the contributing guidelines in there.
One thing that you should definitely change: use an indentation of two spaces.

FRidh · 2018-07-30T18:37:47Z

pkgs/development/python-modules/fluent-logger/default.nix

@@ -0,0 +1,20 @@
+{ pkgs, lib, buildPythonPackage, fetchPypi, msgpack }:


FRidh · 2018-07-30T18:37:57Z

pkgs/development/python-modules/fluent-logger/default.nix

+  };
+
+  propagatedBuildInputs = [ msgpack ];
+  doCheck = false;


Why are the tests disabled? Please include a comment.

dotlambda · 2018-07-30T18:49:57Z

pkgs/development/python-modules/fluent-logger/default.nix

+
+  meta = with pkgs.stdenv.lib; {
+    description = "A structured logger for Fluentd (Python)";
+    homepage = "https://github.com/fluent/fluent-logger-python";


ngortheone · 2018-07-30T19:32:59Z

@dotlambda @FRidh addressed everything you pointed out.

dotlambda · 2018-07-30T20:12:50Z

@ngortheone The commit message still needs to be changed to pythonPackages.fluent-logger: init at 0.9.3.

ngortheone · 2018-07-30T20:14:08Z

@dotlambda done

dotlambda · 2018-07-30T20:23:57Z

pkgs/development/python-modules/fluent-logger/default.nix

+    description = "A structured logger for Fluentd (Python)";
+    homepage = https://github.com/fluent/fluent-logger-python;
+    license = licenses.asl20;
+  };


Do you want to add yourself as a maintainer?

@dotlambda I'd prefer not to, unless it is absolutely required. I am not a python expert, I am just adding missing dependency for my project.

dotlambda · 2018-07-30T20:24:18Z

@GrahamcOfBorg build python2.pkgs.fluent-logger python3.pkgs.fluent-logger

GrahamcOfBorg · 2018-07-30T20:25:00Z

Success on aarch64-linux (full log)

Attempted: python2.pkgs.fluent-logger, python3.pkgs.fluent-logger

Partial log (click to expand)

Successfully installed fluent-logger-0.9.3
/build/fluent-logger-0.9.3
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/h0lv6d0mrr6nfp30bfrc0yk8j895jvq8-python3.6-fluent-logger-0.9.3
strip is /nix/store/zrs21zqcchgyabjf4xfimncdq16njizc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/h0lv6d0mrr6nfp30bfrc0yk8j895jvq8-python3.6-fluent-logger-0.9.3/lib
patching script interpreter paths in /nix/store/h0lv6d0mrr6nfp30bfrc0yk8j895jvq8-python3.6-fluent-logger-0.9.3
checking for references to /build in /nix/store/h0lv6d0mrr6nfp30bfrc0yk8j895jvq8-python3.6-fluent-logger-0.9.3...
/nix/store/49y4f0bwvcbd2py2l59004993l4i5y97-python2.7-fluent-logger-0.9.3
/nix/store/h0lv6d0mrr6nfp30bfrc0yk8j895jvq8-python3.6-fluent-logger-0.9.3

GrahamcOfBorg · 2018-07-30T20:25:12Z

Success on x86_64-linux (full log)

Attempted: python2.pkgs.fluent-logger, python3.pkgs.fluent-logger

Partial log (click to expand)

Successfully installed fluent-logger-0.9.3
/build/fluent-logger-0.9.3
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/z286813cr62xxpycs0qhyya1fpj2xvbw-python3.6-fluent-logger-0.9.3
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/z286813cr62xxpycs0qhyya1fpj2xvbw-python3.6-fluent-logger-0.9.3/lib
patching script interpreter paths in /nix/store/z286813cr62xxpycs0qhyya1fpj2xvbw-python3.6-fluent-logger-0.9.3
checking for references to /build in /nix/store/z286813cr62xxpycs0qhyya1fpj2xvbw-python3.6-fluent-logger-0.9.3...
/nix/store/v7qknnk9m4ih70ciichddaz44pq4c3lx-python2.7-fluent-logger-0.9.3
/nix/store/z286813cr62xxpycs0qhyya1fpj2xvbw-python3.6-fluent-logger-0.9.3

ngortheone · 2018-07-31T13:59:33Z

@dotlambda @FRidh can you cherry pick this to 18.03? I can create a PR (I am not sure what is the standard process for back-porting changes)

pythonPackages.fluent-logger: init at 0.9.3 (#44236)

ngortheone requested a review from FRidh as a code owner July 30, 2018 17:14

GrahamcOfBorg added the 6.topic: python label Jul 30, 2018

dotlambda requested changes Jul 30, 2018

View reviewed changes

GrahamcOfBorg added 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jul 30, 2018

FRidh reviewed Jul 30, 2018

View reviewed changes

dotlambda reviewed Jul 30, 2018

View reviewed changes

dotlambda changed the title ~~Pypi fluent-logger package~~ pythonPackages.fluent-logger: init at 0.9.3 Jul 30, 2018

pythonPackages.fluent-logger: init at 0.9.3.

a32ba66

dotlambda reviewed Jul 30, 2018

View reviewed changes

dotlambda merged commit 742627f into NixOS:master Jul 30, 2018

ngortheone deleted the fluent-logger branch July 31, 2018 00:42

ngortheone mentioned this pull request Jul 31, 2018

pythonPackages.fluent-logger: init at 0.9.3 (#44236) #44270

Merged

copumpkin added a commit that referenced this pull request Jul 31, 2018

Merge pull request #44270 from ngortheone/release-18.03

0d78855

pythonPackages.fluent-logger: init at 0.9.3 (#44236)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pythonPackages.fluent-logger: init at 0.9.3 #44236

pythonPackages.fluent-logger: init at 0.9.3 #44236

ngortheone commented Jul 30, 2018 •

edited

dotlambda left a comment

dotlambda Jul 30, 2018

dotlambda Jul 30, 2018

dotlambda Jul 30, 2018

ngortheone commented Jul 30, 2018

dotlambda commented Jul 30, 2018

FRidh Jul 30, 2018

FRidh Jul 30, 2018

dotlambda Jul 30, 2018

ngortheone commented Jul 30, 2018

dotlambda commented Jul 30, 2018

ngortheone commented Jul 30, 2018

dotlambda Jul 30, 2018

ngortheone Jul 30, 2018

dotlambda commented Jul 30, 2018

GrahamcOfBorg commented Jul 30, 2018

GrahamcOfBorg commented Jul 30, 2018

ngortheone commented Jul 31, 2018

		@@ -0,0 +1,20 @@
		{ pkgs, lib, buildPythonPackage, fetchPypi, msgpack }:

pythonPackages.fluent-logger: init at 0.9.3 #44236

pythonPackages.fluent-logger: init at 0.9.3 #44236

Conversation

ngortheone commented Jul 30, 2018 • edited

Motivation for this change

Things done

dotlambda left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ngortheone commented Jul 30, 2018

dotlambda commented Jul 30, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ngortheone commented Jul 30, 2018

dotlambda commented Jul 30, 2018

ngortheone commented Jul 30, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dotlambda commented Jul 30, 2018

GrahamcOfBorg commented Jul 30, 2018

GrahamcOfBorg commented Jul 30, 2018

ngortheone commented Jul 31, 2018

ngortheone commented Jul 30, 2018 •

edited