Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crystal: 0.25.0 -> 0.25.1; mint 0.1.0 -> 0.2.0 #44237

Merged
merged 1 commit into from Jul 31, 2018
Merged

crystal: 0.25.0 -> 0.25.1; mint 0.1.0 -> 0.2.0 #44237

merged 1 commit into from Jul 31, 2018

Conversation

manveru
Copy link
Contributor

@manveru manveru commented Jul 30, 2018 •
edited

Motivation for this change

Crystal upgrade is needed because of bugs in File handling (among others). See https://github.com/crystal-lang/crystal/releases/tag/0.25.1 for details. Those bugs prevented kemal to compile, which is used by Mint.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@infinisil
Copy link
Member

@GrahamcOfBorg build crystal

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: crystal

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: crystal

Partial log (click to expand)

wrong ELF type
shrinking /nix/store/2g4yl2ls0lrna8n3ndp9irpw9yzhm9a7-crystal-0.25.1/lib/crystal/llvm/ext/llvm_ext.o
wrong ELF type
shrinking /nix/store/2g4yl2ls0lrna8n3ndp9irpw9yzhm9a7-crystal-0.25.1/bin/.crystal-wrapped
gzipping man pages under /nix/store/2g4yl2ls0lrna8n3ndp9irpw9yzhm9a7-crystal-0.25.1/share/man/
patching script interpreter paths in /nix/store/2g4yl2ls0lrna8n3ndp9irpw9yzhm9a7-crystal-0.25.1
checking for references to /build in /nix/store/2g4yl2ls0lrna8n3ndp9irpw9yzhm9a7-crystal-0.25.1...
wrong ELF type
wrong ELF type
/nix/store/2g4yl2ls0lrna8n3ndp9irpw9yzhm9a7-crystal-0.25.1

@xeji
Copy link
Contributor

xeji commented Jul 30, 2018

@GrahamcOfBorg build mint shards crystal

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: mint, shards, crystal

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: shards, crystal

The following builds were skipped because they don't evaluate on x86_64-darwin: mint

Partial log (click to expand)

cannot build derivation '/nix/store/892lcqjw1zh2nsv84gkwvlnlpz7s5rcs-openssl-1.0.2o.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/flxd4fgx73cl9ljq65p06rsicczvm71v-libevent-2.1.8.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/w4n4vjakqjz3a65f59hx8nqxh3hr1523-libssh2-1.8.0.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/ssrww5b810b92b21ihn3wkgyyam4s3ff-nghttp2-1.32.0.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/jv3r1rsxnzsd9iyhdrqxk2xsa9p04bn5-curl-7.61.0.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/sdjjzf350rqsjyr4ci9p4d12mxfljfm3-0.25.1.tar.gz.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/nyhjacapy6v4fyrn9d42b2vq9965b684-crystal-0.25.1-1-darwin-x86_64.tar.gz.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/bwj20zlb5av2i4qb9w9dy6rzhw7kh4bz-crystal-0.25.1.drv': 12 dependencies couldn't be built
cannot build derivation '/nix/store/0l4930fvpjb48p709jg6h722qribpr50-shards-0.8.1.drv': 5 dependencies couldn't be built
error: build of '/nix/store/0l4930fvpjb48p709jg6h722qribpr50-shards-0.8.1.drv', '/nix/store/bwj20zlb5av2i4qb9w9dy6rzhw7kh4bz-crystal-0.25.1.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: mint, shards, crystal

Partial log (click to expand)

cannot build derivation '/nix/store/n6n1filk16cfywqp7lxws744cq69mvfq-libarchive-3.3.2.drv': 12 dependencies couldn't be built
cannot build derivation '/nix/store/brzbcg1sl03wyxn42i4j8f9zf744j8j8-cmake-3.11.2.drv': 11 dependencies couldn't be built
cannot build derivation '/nix/store/ajv94pdmdmwzl51m750ic74dn4w8bzg6-llvm-5.0.2.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/vmzwan8wi0cca141vid3ylv3hdzpxllc-clang-5.0.2.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/3l79a74gj75n3w77i4dhlg1vn85znrzm-compiler-rt-5.0.2.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/1vcr0h7i6ck9ym0ay84fh003safni5w2-clang-wrapper-5.0.2.drv': 10 dependencies couldn't be built
cannot build derivation '/nix/store/k5m0p8705s083qsc4wa7ydrldzix4wbs-crystal-0.25.1.drv': 9 dependencies couldn't be built
cannot build derivation '/nix/store/cgy3s355c8vj0lh5m6yp1l7vh5iy1z83-mint-0.2.0.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/kx245761mnal74s3bqn8dcyf783dqi8h-shards-0.8.1.drv': 5 dependencies couldn't be built
error: build of '/nix/store/cgy3s355c8vj0lh5m6yp1l7vh5iy1z83-mint-0.2.0.drv', '/nix/store/k5m0p8705s083qsc4wa7ydrldzix4wbs-crystal-0.25.1.drv', '/nix/store/kx245761mnal74s3bqn8dcyf783dqi8h-shards-0.8.1.drv' failed

@xeji
Copy link
Contributor

xeji commented Jul 31, 2018

let's try again after some mass-rebuilding change on master was reverted.
@GrahamcOfBorg build mint shards crystal

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: mint, shards, crystal

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: shards, crystal

The following builds were skipped because they don't evaluate on x86_64-darwin: mint

Partial log (click to expand)

building
build flags: SHELL=/nix/store/qb76s7s3p6pnsi7082sjfc7rb64f3s6a-bash-4.4-p23/bin/bash CRFLAGS=--release
crystal build src/shards.cr -o bin/shards --release
installing
post-installation fixup
strip is /nix/store/qfxcr8c4fg7lkybrny9n2sb77bmippdx-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/04291f0qvcqism4dnkjs899magg427k1-shards-0.8.1/bin
patching script interpreter paths in /nix/store/04291f0qvcqism4dnkjs899magg427k1-shards-0.8.1
/nix/store/04291f0qvcqism4dnkjs899magg427k1-shards-0.8.1
/nix/store/gn85hki6lcppmaw8dbf61lvy6h04gmb3-crystal-0.25.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: mint, shards, crystal

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/v2rqpv5vw19b6ad1v70xd8p0p4kcgixw-mint-0.2.0
shrinking /nix/store/v2rqpv5vw19b6ad1v70xd8p0p4kcgixw-mint-0.2.0/bin/mint
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/v2rqpv5vw19b6ad1v70xd8p0p4kcgixw-mint-0.2.0/bin
patching script interpreter paths in /nix/store/v2rqpv5vw19b6ad1v70xd8p0p4kcgixw-mint-0.2.0
checking for references to /build in /nix/store/v2rqpv5vw19b6ad1v70xd8p0p4kcgixw-mint-0.2.0...
/nix/store/v2rqpv5vw19b6ad1v70xd8p0p4kcgixw-mint-0.2.0
/nix/store/lz50fwsrw7cv05yacfm5l6pp95xp603v-shards-0.8.1
/nix/store/2g4yl2ls0lrna8n3ndp9irpw9yzhm9a7-crystal-0.25.1

@xeji
Copy link
Contributor

xeji commented Jul 31, 2018

In the future, please make a separate commit for each package you change to provide a nicer history. Thank you.

@xeji xeji merged commit 0f3eaa0 into NixOS:master Jul 31, 2018
@manveru manveru deleted the upgrade-crystal-and-mint branch December 12, 2019 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@manveru @infinisil @GrahamcOfBorg @xeji