New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: Houses can accept up to 16 different cargo types via NewGRF #6872
Conversation
c6715ee
to
b06076f
Compare
b06076f
to
0f90884
Compare
We recently switched from Jenkins as CI to Azure Pipelines as CI. This means you need to rebase before this Pull Request will pass its checks. Sorry for the troubles! |
0f90884
to
281e88b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code reads fine for me. I agree with @nielsmh wrt uint/CargoID - the numbers are used as array sizes/indices, CargoID doesn't seem appropriate
New Action0 property 23 for feature 07, variable length, format B n*(B B). Initial byte is number of structures following. First byte in structure is cargo id, second is acceptance level in 1/8 units.
281e88b
to
0911516
Compare
New Action0 property 23 for feature 07, variable length, format B n*(B B). Initial byte is number of structures following. First byte in structure is cargo id, second is acceptance level in 1/8 units.
This doesn't affect savegame data, and shouldn't affect backwards compatibility with NewGRFs. Any NewGRF using the new property would not load on older versions without the property, but chance is they also depend on more than 32 cargo types then.