Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an easy way to update Picard versions #120

Merged
merged 1 commit into from Aug 8, 2018

Conversation

samj1912
Copy link
Collaborator

Summary

  • This is a…
    • Bug fix
    • Feature addition
    • Refactoring
    • Minor / simple change (like a typo)
    • Other
  • Describe this change in 1-2 sentences:

Problem

  • JIRA ticket (optional): PW-XXX

Solution

Action

@samj1912
Copy link
Collaborator Author

We can move this to consul for easy updates too.

@samj1912 samj1912 requested a review from zas July 30, 2018 13:11
@rdswift
Copy link
Contributor

rdswift commented Jul 30, 2018

Would this also be used to update the version information in the default_config.py file for the api releases endpoint (if and when the PR is merged)?

EDIT: Please disregard my note. I just went through the code and see that the two are separate parts of the same configuration file. I should have looked more closely originally. Sorry about that.

@rdswift
Copy link
Contributor

rdswift commented Aug 2, 2018

@samj1912, with this being developed in parallel with PR-119 I think that the current release version tag will now be entered in two places: once for the api and once for this easy updating. Ideally it should probably only be entered in one place and copied to the other variable. This would avoid the situation where the website and the api display different versions because the information was only updated in one place.

@samj1912 samj1912 force-pushed the easyup branch 2 times, most recently from c2a403e to 25b42dd Compare August 8, 2018 10:15
@samj1912 samj1912 merged commit 9afb4d5 into metabrainz:master Aug 8, 2018
@samj1912 samj1912 deleted the easyup branch August 8, 2018 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants