pythonPackages.reportlab: remove test files that require network for the tests to pass #44244
Conversation
| @@ -25,6 +25,9 @@ in buildPythonPackage rec { | |||
| postPatch = '' | |||
| rm tests/test_graphics_barcode.py | |||
| rm tests/test_graphics_render.py | |||
| rm tests/test_lib_utils.py | |||
| rm tests/test_platypus_breaking.py | |||
| rm tests/test_platypus_general.py | |||
There was a problem hiding this comment.
You should add comments explaining why which test is removed.
| @@ -22,9 +22,13 @@ in buildPythonPackage rec { | |||
|
|
|||
| buildInputs = [ ft pillow ]; | |||
|
|
|||
| # Remove all the test files that require access to the internet to pass. | |||
There was a problem hiding this comment.
Is that also the case for the two that were already disabled?
There was a problem hiding this comment.
they were originally removed in 9558ab1 but I did some checking and they are failing the checkPhase executes LC_ALL="en_US.UTF-8" ${python.interpreter} tests/runAll.py but the tests upstream run from within the tests folder.
I'm going to do some testing and will rebase this and PTAL you.
| rm tests/test_lib_utils.py | ||
| rm tests/test_platypus_general.py | ||
|
|
||
| # Remove the tests that require Vera fonts installed |
There was a problem hiding this comment.
@dotlambda I can probably figure out how to get Vera font for the test, (I tried adding pkgs.ttf-bitstream-vera to the checkInputs but it did not work).
@dotlambda PTAL.
There was a problem hiding this comment.
I don't think that's necessary. Thanks a lot for your work!
|
@GrahamcOfBorg build reportlab |
|
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: reportlab Partial log (click to expand)
|
|
No attempt on x86_64-linux (full log) The following builds were skipped because they don't evaluate on x86_64-linux: reportlab Partial log (click to expand)
|
dotlambda
changed the title
|
@GrahamcOfBorg build python2.pkgs.reportlab python3.pkgs.reportlab |
|
Success on x86_64-linux (full log) Attempted: python2.pkgs.reportlab, python3.pkgs.reportlab Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: python2.pkgs.reportlab, python3.pkgs.reportlab Partial log (click to expand)
|
Motivation for this change
This PR removes the tests that require the network to pass.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)closes #44204
cc @FRidh @eadwu