Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages: remove unmaintained graphite-related stuff #44246

Closed
wants to merge 2 commits into from
Closed

pythonPackages: remove unmaintained graphite-related stuff #44246

wants to merge 2 commits into from

Conversation

dotlambda
Copy link
Member

Motivation for this change

Fixes #30891.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

I'm not sure if I was a little too eager to remove the packages. The second commit could be left out.

Also, the graphite module is now broken. Is there a way to mark it as such?

cc @FRidh @adisbladis @offlinehacker @rickynils

@dotlambda dotlambda requested a review from FRidh as a code owner July 30, 2018 21:33
@FRidh
Copy link
Member

FRidh commented Jul 31, 2018

cc @basvandijk

@basvandijk
Copy link
Member

I'm currently using the graphite module (with web and carbon enabled) in pretty much all our production machines. So I would be sad to see this go.

IIUC the problem is that the code is not consistent with the rest of python-packages.nix and the packages are not up to date with the latest graphite release. Can't we at first just move the packages to subdirs of pkgs/development/python-modules. Then maybe I can spent some time upgrading the packages.

If it has to go the more responsible thing to do would be to deprecate this in 18.09 and then remove it in 19.03.

@dotlambda
Copy link
Member Author

dotlambda commented Jul 31, 2018 •
edited

Sure, if you are willing to maintain these packages feel free to create a PR in which you move them and correct everything that was mentioned in #30891. This PR was created because those in the maintainers field did not react to above mentioned issue and also because nobody else seemed to care about the massively outdated packages.

@FRidh
Copy link
Member

FRidh commented Jul 31, 2018

@basvandijk the moving of expressions began already a year ago. What is left are expressions that apparently are unmaintained. If people depend on them, they need to actively maintain them.

@basvandijk basvandijk mentioned this pull request Jul 31, 2018
Merged
9 tasks
@basvandijk
Copy link
Member

Ok I've made a PR #44276. Let me know what you think.

@dotlambda dotlambda deleted the remove-graphite-unmaintained branch January 17, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
2.status: work-in-progress 6.topic: python 8.has: clean-up 9.needs: changelog 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dotlambda @FRidh @basvandijk @GrahamcOfBorg