Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] mariadb: add v10.3.8 #44241

Closed
wants to merge 1 commit into from
Closed

[WIP] mariadb: add v10.3.8 #44241

wants to merge 1 commit into from

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Jul 30, 2018 •
edited

Motivation for this change

Could you please add MariaDB version 10.3.8. It is latest release of 10.3 branch, which is stable (GA). I've split the package into two parts: client and server. This was done at postInstall stage. The goal for the split is to avoid duplicating binary files in client and server packages. Could you please fix, in case I've done something incorrectly. Thank you in advance.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@matthewbauer
Copy link
Member

@GrahamcOfBorg mariadb103

Looks okay - but I actually think we want to just bump the current mariadb. Unless there is some reason to keep the old one we usually just bump to latest.

@xeji
Copy link
Contributor

xeji commented Aug 2, 2018

closing since mariadb was bumped to 10.3.8 in 00ab5c5.

@xeji xeji closed this Aug 2, 2018
@Izorkin
Copy link
Contributor Author

Izorkin commented Aug 2, 2018

@xeji there are major differences between 10.2 and 10.3, therefore just bumping version makes client build fail. I can redo this PR.

builder for '/nix/store/5073nws50rfxbjhv0ma4vch2dvsindzg-mariadb-client-10.3.8.drv' failed with exit code 2; last 10 log lines:
  [ 40%] Building C object strings/CMakeFiles/strings.dir/strxnmov.c.o
  [ 41%] Building C object strings/CMakeFiles/strings.dir/xml.c.o
  [ 41%] Building C object strings/CMakeFiles/strings.dir/strmov_overlapp.c.o
  [ 41%] Building C object strings/CMakeFiles/strings.dir/my_strchr.c.o
  [ 41%] Building C object strings/CMakeFiles/strings.dir/strcont.c.o
  [ 41%] Building C object strings/CMakeFiles/strings.dir/strappend.c.o
  [ 42%] Building C object strings/CMakeFiles/strings.dir/json_lib.c.o
  [ 42%] Linking C static library libstrings.a
  [ 42%] Built target strings
  make: *** [Makefile:163: all] Error 2

@xeji
Copy link
Contributor

xeji commented Aug 2, 2018 via email

@Izorkin
Copy link
Contributor Author

Izorkin commented Aug 2, 2018

@xeji Open new PR - #44343

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Izorkin @matthewbauer @xeji @GrahamcOfBorg