improved coroutine cancel semantics #1307
Merged
+486
−142
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a prerequisite of #1294.
This makes the alignment of
promise
a minimum of 8 (which was already the alignment on x86_64), which gives us 3 bits in the atomic state of a coroutine.These 3 bits are used as follows (starting with LSB):
I had to add more atomicrmw operations to make this all work. The atomic ops are now:
suspend
resume
cancel
await
return
This fixes a few issues:
#1163 is still a problem - an awaiting coroutine is indistinguishable from a suspended coroutine to zig.
With this,
cancel
becomes thread-safe, just likeawait
already is.