Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add various lua modules #44235

Merged
merged 9 commits into from Aug 17, 2018
Merged

add various lua modules #44235

merged 9 commits into from Aug 17, 2018

Conversation

vcunat
Copy link
Member

@vcunat vcunat commented Jul 30, 2018

I'll merge in a few days if there are no comments. The 'http' module of knot-resolver seems to work OK with it, though that's probably just very shallow test of most of the added lua modules.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • N/A Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: knot-resolver

Partial log (click to expand)

  /nix/store/9hg1hlgyz0h05vh9jd1yqnzdsdbvv0rf-libcap-ng-0.7.9
  /nix/store/bbbfaw9089yfs11hc5qw6jg2a01dzssv-luajit-2.1.0-beta3
  /nix/store/n462f2d2fh1fcxq9g29s3lnxwjfdv0zx-lmdb-0.9.22
  /nix/store/z5iifyz272q6qb9z14zq8365326wv4v3-knot-dns-2.6.8
copying path '/nix/store/n462f2d2fh1fcxq9g29s3lnxwjfdv0zx-lmdb-0.9.22' from 'https://cache.nixos.org'...
copying path '/nix/store/bbbfaw9089yfs11hc5qw6jg2a01dzssv-luajit-2.1.0-beta3' from 'https://cache.nixos.org'...
copying path '/nix/store/9hg1hlgyz0h05vh9jd1yqnzdsdbvv0rf-libcap-ng-0.7.9' from 'https://cache.nixos.org'...
copying path '/nix/store/z5iifyz272q6qb9z14zq8365326wv4v3-knot-dns-2.6.8' from 'https://cache.nixos.org'...
copying path '/nix/store/8jb3r4bbzhxcsj5qgxzbf9ymwdz7f6qw-knot-resolver-2.4.0' from 'https://cache.nixos.org'...
/nix/store/8jb3r4bbzhxcsj5qgxzbf9ymwdz7f6qw-knot-resolver-2.4.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: knot-resolver

Partial log (click to expand)

these paths will be fetched (0.93 MiB download, 4.22 MiB unpacked):
  /nix/store/6c2nqnfz3i9s2kwbia5haq85abnprbz2-luajit-2.1.0-beta3
  /nix/store/ddpj1ca7mxjy57b0a8fma1kcgdni0zln-knot-resolver-2.4.0
  /nix/store/v8b3y4icqbcvyvckm9lxlpil7ignm4bf-knot-dns-2.6.8
  /nix/store/vxv3iv2qav71q7c1gkd7jdjzdqwy4i1m-lmdb-0.9.22
copying path '/nix/store/vxv3iv2qav71q7c1gkd7jdjzdqwy4i1m-lmdb-0.9.22' from 'https://cache.nixos.org'...
copying path '/nix/store/6c2nqnfz3i9s2kwbia5haq85abnprbz2-luajit-2.1.0-beta3' from 'https://cache.nixos.org'...
copying path '/nix/store/v8b3y4icqbcvyvckm9lxlpil7ignm4bf-knot-dns-2.6.8' from 'https://cache.nixos.org'...
copying path '/nix/store/ddpj1ca7mxjy57b0a8fma1kcgdni0zln-knot-resolver-2.4.0' from 'https://cache.nixos.org'...
/nix/store/ddpj1ca7mxjy57b0a8fma1kcgdni0zln-knot-resolver-2.4.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: knot-resolver

Partial log (click to expand)

these paths will be fetched (0.99 MiB download, 4.17 MiB unpacked):
  /nix/store/03gk72hk8wp1xjnyzi79jc4xxshg8fqf-luajit-2.1.0-beta3
  /nix/store/ab1rwcqirffp350ddd1jn9rwrj7a2zfa-knot-dns-2.6.8
  /nix/store/aqbf5knvvb4d40bz01q2qvarf9zcv19s-knot-resolver-2.4.0
  /nix/store/xfznf07wj4bgrajyd6d1hhbpxjfskn5b-lmdb-0.9.22
copying path '/nix/store/xfznf07wj4bgrajyd6d1hhbpxjfskn5b-lmdb-0.9.22' from 'https://cache.nixos.org'...
copying path '/nix/store/03gk72hk8wp1xjnyzi79jc4xxshg8fqf-luajit-2.1.0-beta3' from 'https://cache.nixos.org'...
copying path '/nix/store/ab1rwcqirffp350ddd1jn9rwrj7a2zfa-knot-dns-2.6.8' from 'https://cache.nixos.org'...
copying path '/nix/store/aqbf5knvvb4d40bz01q2qvarf9zcv19s-knot-resolver-2.4.0' from 'https://cache.nixos.org'...
/nix/store/aqbf5knvvb4d40bz01q2qvarf9zcv19s-knot-resolver-2.4.0

@teto
Copy link
Member

teto commented Jul 31, 2018

I've been too busy to rebase it but if you are interested in lua, there is a luarocks2nix utility in #33903

@vcunat
Copy link
Member Author

vcunat commented Jul 31, 2018

Oh, interesting. Such a utility might have saved me a small bit of time with this, but that PR is really large for me to take it on (and my main problem was insufficient understanding of lua packaging conventions anyway).

aanderse pushed a commit to aanderse/nixpkgs that referenced this pull request Aug 17, 2018
@vcunat
Merge NixOS#44235: add various lua modules
fe32659
@vcunat vcunat merged commit 2d75c47 into NixOS:master Aug 17, 2018
@grahamc
Copy link
Member

grahamc commented Aug 17, 2018

Nice!!

@vcunat vcunat deleted the p/kresd-http branch August 17, 2018 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vcunat @GrahamcOfBorg @teto @grahamc