Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mpv: add lcms2 support #44243

Merged
merged 1 commit into from Jul 31, 2018
Merged

mpv: add lcms2 support #44243

merged 1 commit into from Jul 31, 2018

Conversation

d3rped
Copy link
Contributor

@d3rped d3rped commented Jul 30, 2018 •
edited

Motivation for this change

The mpv package is missing icc/color profile support which I (and hopefully others) would like to use.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Jul 31, 2018

@GrahamcOfBorg build mpv

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: mpv

Partial log (click to expand)

[  9/418] Compiling etc/builtin.conf
[ 10/418] Compiling sub/osd_font.otf
[ 11/418] Compiling player/lua/defaults.lua
/bin/sh: []: command not found

Waf: Leaving directory `/private/tmp/nix-build-mpv-0.29.0.drv-0/source/build'
Build failed
 -> task in 'osdep/macOS_swift.o osdep/macOS_swift.h osdep/macOS_swift.swiftmodule' failed with exit status 127 (run with -v to display more information)
builder for '/nix/store/digyc8aq1ky9swf1p5drk0v3xwj24izh-mpv-0.29.0.drv' failed with exit code 1
error: build of '/nix/store/digyc8aq1ky9swf1p5drk0v3xwj24izh-mpv-0.29.0.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: mpv

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/q2rqskd8kgms7h1i1k0790ngybvc3yc5-mpv-0.29.0
shrinking /nix/store/q2rqskd8kgms7h1i1k0790ngybvc3yc5-mpv-0.29.0/lib/libmpv.so.1.101.0
shrinking /nix/store/q2rqskd8kgms7h1i1k0790ngybvc3yc5-mpv-0.29.0/bin/.mpv-wrapped
gzipping man pages under /nix/store/q2rqskd8kgms7h1i1k0790ngybvc3yc5-mpv-0.29.0/share/man/
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/q2rqskd8kgms7h1i1k0790ngybvc3yc5-mpv-0.29.0/lib  /nix/store/q2rqskd8kgms7h1i1k0790ngybvc3yc5-mpv-0.29.0/bin
patching script interpreter paths in /nix/store/q2rqskd8kgms7h1i1k0790ngybvc3yc5-mpv-0.29.0
checking for references to /build in /nix/store/q2rqskd8kgms7h1i1k0790ngybvc3yc5-mpv-0.29.0...
/nix/store/q2rqskd8kgms7h1i1k0790ngybvc3yc5-mpv-0.29.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: mpv

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/8p08pd9piw8s3w9g7vklw5imq6952nnw-mpv-0.29.0
shrinking /nix/store/8p08pd9piw8s3w9g7vklw5imq6952nnw-mpv-0.29.0/lib/libmpv.so.1.101.0
shrinking /nix/store/8p08pd9piw8s3w9g7vklw5imq6952nnw-mpv-0.29.0/bin/.mpv-wrapped
gzipping man pages under /nix/store/8p08pd9piw8s3w9g7vklw5imq6952nnw-mpv-0.29.0/share/man/
strip is /nix/store/zrs21zqcchgyabjf4xfimncdq16njizc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/8p08pd9piw8s3w9g7vklw5imq6952nnw-mpv-0.29.0/lib  /nix/store/8p08pd9piw8s3w9g7vklw5imq6952nnw-mpv-0.29.0/bin
patching script interpreter paths in /nix/store/8p08pd9piw8s3w9g7vklw5imq6952nnw-mpv-0.29.0
checking for references to /build in /nix/store/8p08pd9piw8s3w9g7vklw5imq6952nnw-mpv-0.29.0...
/nix/store/8p08pd9piw8s3w9g7vklw5imq6952nnw-mpv-0.29.0

@Mic92 Mic92 merged commit 8afb618 into NixOS:master Jul 31, 2018
@Mic92
Copy link
Member

Mic92 commented Jul 31, 2018

The error here on macOS was introduced by an earlier change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@d3rped @Mic92 @GrahamcOfBorg @Janik-Haag