Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.contextvars: 2.2 -> 2.3 #44234

Merged
merged 1 commit into from Jul 30, 2018
Merged

pythonPackages.contextvars: 2.2 -> 2.3 #44234

merged 1 commit into from Jul 30, 2018

Conversation

catern
Copy link
Contributor

@catern catern commented Jul 30, 2018

Motivation for this change

This fixes the build of this package, which was previously broken because pythonPackages.immutables was upgraded, and this package expressed a dependency on a specific version of "immutables". The only change in this new version is to depend on the new version of immutables.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@catern catern requested a review from FRidh as a code owner July 30, 2018 16:53
dotlambda
dotlambda approved these changes Jul 30, 2018
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Btw, should we add something like

contextvars = if (pythonAtLeast "3.7") then null else callPackage ../development/python-modules/contextvars {};

to python-packages.nix?

@FRidh
Copy link
Member

FRidh commented Jul 30, 2018

@dotlambda we could add it but it shouldn't be necessary. The only reason we add these things is because packages don't always express their dependencies correctly.

@dotlambda
Copy link
Member

@FRidh All right, the only dependent python37.pkgs.trio specifies the requirement correctly, so let's just merge.

eadwu pushed a commit to eadwu/nixpkgs that referenced this pull request Jul 30, 2018
@catern @dotlambda
pythonPackages.contextvars: 2.2 -> 2.3 (NixOS#44234)
de311d9
@dotlambda dotlambda merged commit a52b6b1 into NixOS:master Jul 30, 2018
@dotlambda
Copy link
Member

GitHub seems to have fucked up and allowed me to merge twice :D

@FRidh
Copy link
Member

FRidh commented Jul 30, 2018

Nice, an empty commit. I guess that's something for support@github.com
There goes our beautiful history :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@catern @FRidh @dotlambda @GrahamcOfBorg