Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.simpleldap: remove #43782

Merged
merged 2 commits into from Jul 19, 2018
Merged

python3Packages.simpleldap: remove #43782

merged 2 commits into from Jul 19, 2018

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Jul 18, 2018 •
edited

Motivation for this change

Fairly outdated and incompatible with Python 3, see the following links
for further reference:

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Ma27 Ma27 requested a review from FRidh as a code owner July 18, 2018 23:23
@Ma27
Copy link
Member Author

Ma27 commented Jul 18, 2018 

Result in /tmp/nox-review-8rjpzsed
total 8
lrwxrwxrwx 1 ma27 users 68 Jul 19 01:25 result -> /nix/store/r4xhm3g1gq4sla9zsm36nl6zq98kqhfh-python2.7-simpleldap-0.8
lrwxrwxrwx 1 ma27 users 68 Jul 19 01:25 result-2 -> /nix/store/jjnlacb9yasg82wgaywz4vh2za0q2sf4-python3.6-simpleldap-0.8

@dotlambda
Copy link
Member

Judging from https://github.com/gdub/python-simpleldap/blob/0.8/setup.py#L12-L14, we should set disabled = isPy3k.

dotlambda
dotlambda reviewed Jul 19, 2018
View reviewed changes
pkgs/development/python-modules/simpleldap/default.nix Outdated
pname = "simpleldap";
version = "0.8";

src = fetchFromGitHub {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason you switched to fetchFromGitHub? Please add an inline comment.

@dotlambda
Copy link
Member

dotlambda commented Jul 19, 2018 •
edited

I think we should just remove this package: It hasn't been updated since 2014 and its only dependent, inginious, is marked as broken since 6111168. Inginious should either be updated to the most recent version, which replaces simpleldap by ldap3 or completely removed as @layus suggested in #31975 (comment).

@Ma27
Copy link
Member Author

Ma27 commented Jul 19, 2018

@dotlambda thanks for elaborating, I dropped both of these packages, a broken one is obviiously not in use and simpleldap is way too outdated which is why I should use a more recent alternative 😅

@Ma27 Ma27 changed the title python3Packages.simpleldap: fix build python3Packages.simpleldap: remove Jul 19, 2018
@dotlambda
Copy link
Member

I dropped both of these packages

Please adjust the commit message of the first commit accordingly.

Ma27 added 2 commits July 19, 2018 17:31
@Ma27
python3Packages.simpleldap: remove
10439f7 
Fairly outdated and incompatible with Python 3, see the following links
for further reference:

* https://github.com/gdub/python-simpleldap/blob/0.8/setup.py#L12-L14
* NixOS#43782 (comment)
@Ma27
inginious: remove
0adca53 
Fallout of 9db7f15ea3ce57eee25458daf87cce7a04ea98b2 which removed
simpleldap.

@layus suggests to remove:

* NixOS#43782 (comment)
* NixOS#31975 (comment)
@Ma27
Copy link
Member Author

Ma27 commented Jul 19, 2018

argh, good catch, sorry :/

@dotlambda dotlambda merged commit e7e5aaa into NixOS:master Jul 19, 2018
@Ma27 Ma27 deleted the fix-simpleldap-python3 branch July 19, 2018 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: nixos 6.topic: python 8.has: clean-up 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @dotlambda @GrahamcOfBorg