Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gpm: patch to fix w/musl, good for general use #43759

Merged
merged 1 commit into from Jul 19, 2018
Merged

gpm: patch to fix w/musl, good for general use #43759

merged 1 commit into from Jul 19, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jul 18, 2018

Two of the patches fix same issues we fix for glibc,
one of which this replaces (the other touches same
code but on the not-glibc path).

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: gpm

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gpm

Partial log (click to expand)

shrinking /nix/store/kvx6yia7i7jz8cf8v7ls5g2pcazqyiwr-gpm-1.20.7/bin/display-buttons
shrinking /nix/store/kvx6yia7i7jz8cf8v7ls5g2pcazqyiwr-gpm-1.20.7/lib/libgpm.so.2.1.0
shrinking /nix/store/kvx6yia7i7jz8cf8v7ls5g2pcazqyiwr-gpm-1.20.7/sbin/gpm
gzipping man pages under /nix/store/kvx6yia7i7jz8cf8v7ls5g2pcazqyiwr-gpm-1.20.7/share/man/
strip is /nix/store/90vmpr41dzsx350k5argycaf693hnl1l-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/kvx6yia7i7jz8cf8v7ls5g2pcazqyiwr-gpm-1.20.7/lib  /nix/store/kvx6yia7i7jz8cf8v7ls5g2pcazqyiwr-gpm-1.20.7/bin  /nix/store/kvx6yia7i7jz8cf8v7ls5g2pcazqyiwr-gpm-1.20.7/sbin
patching script interpreter paths in /nix/store/kvx6yia7i7jz8cf8v7ls5g2pcazqyiwr-gpm-1.20.7
checking for references to /build in /nix/store/kvx6yia7i7jz8cf8v7ls5g2pcazqyiwr-gpm-1.20.7...
moving /nix/store/kvx6yia7i7jz8cf8v7ls5g2pcazqyiwr-gpm-1.20.7/sbin/* to /nix/store/kvx6yia7i7jz8cf8v7ls5g2pcazqyiwr-gpm-1.20.7/bin
/nix/store/kvx6yia7i7jz8cf8v7ls5g2pcazqyiwr-gpm-1.20.7

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gpm

Partial log (click to expand)

shrinking /nix/store/4n692c26rlz1yf6bplxq2n2qwr4yskjg-gpm-1.20.7/bin/hltest
shrinking /nix/store/4n692c26rlz1yf6bplxq2n2qwr4yskjg-gpm-1.20.7/bin/mev
shrinking /nix/store/4n692c26rlz1yf6bplxq2n2qwr4yskjg-gpm-1.20.7/lib/libgpm.so.2.1.0
gzipping man pages under /nix/store/4n692c26rlz1yf6bplxq2n2qwr4yskjg-gpm-1.20.7/share/man/
strip is /nix/store/7iyn7gn33i7xxjgmwf25k20246y6nd9d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/4n692c26rlz1yf6bplxq2n2qwr4yskjg-gpm-1.20.7/lib  /nix/store/4n692c26rlz1yf6bplxq2n2qwr4yskjg-gpm-1.20.7/bin  /nix/store/4n692c26rlz1yf6bplxq2n2qwr4yskjg-gpm-1.20.7/sbin
patching script interpreter paths in /nix/store/4n692c26rlz1yf6bplxq2n2qwr4yskjg-gpm-1.20.7
checking for references to /build in /nix/store/4n692c26rlz1yf6bplxq2n2qwr4yskjg-gpm-1.20.7...
moving /nix/store/4n692c26rlz1yf6bplxq2n2qwr4yskjg-gpm-1.20.7/sbin/* to /nix/store/4n692c26rlz1yf6bplxq2n2qwr4yskjg-gpm-1.20.7/bin
/nix/store/4n692c26rlz1yf6bplxq2n2qwr4yskjg-gpm-1.20.7

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: gpm

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gpm

Partial log (click to expand)

shrinking /nix/store/4n692c26rlz1yf6bplxq2n2qwr4yskjg-gpm-1.20.7/bin/hltest
shrinking /nix/store/4n692c26rlz1yf6bplxq2n2qwr4yskjg-gpm-1.20.7/bin/mev
shrinking /nix/store/4n692c26rlz1yf6bplxq2n2qwr4yskjg-gpm-1.20.7/lib/libgpm.so.2.1.0
gzipping man pages under /nix/store/4n692c26rlz1yf6bplxq2n2qwr4yskjg-gpm-1.20.7/share/man/
strip is /nix/store/7iyn7gn33i7xxjgmwf25k20246y6nd9d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/4n692c26rlz1yf6bplxq2n2qwr4yskjg-gpm-1.20.7/lib  /nix/store/4n692c26rlz1yf6bplxq2n2qwr4yskjg-gpm-1.20.7/bin  /nix/store/4n692c26rlz1yf6bplxq2n2qwr4yskjg-gpm-1.20.7/sbin
patching script interpreter paths in /nix/store/4n692c26rlz1yf6bplxq2n2qwr4yskjg-gpm-1.20.7
checking for references to /build in /nix/store/4n692c26rlz1yf6bplxq2n2qwr4yskjg-gpm-1.20.7...
moving /nix/store/4n692c26rlz1yf6bplxq2n2qwr4yskjg-gpm-1.20.7/sbin/* to /nix/store/4n692c26rlz1yf6bplxq2n2qwr4yskjg-gpm-1.20.7/bin
/nix/store/4n692c26rlz1yf6bplxq2n2qwr4yskjg-gpm-1.20.7

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gpm

Partial log (click to expand)

shrinking /nix/store/kvx6yia7i7jz8cf8v7ls5g2pcazqyiwr-gpm-1.20.7/bin/get-versions
shrinking /nix/store/kvx6yia7i7jz8cf8v7ls5g2pcazqyiwr-gpm-1.20.7/bin/disable-paste
shrinking /nix/store/kvx6yia7i7jz8cf8v7ls5g2pcazqyiwr-gpm-1.20.7/sbin/gpm
gzipping man pages under /nix/store/kvx6yia7i7jz8cf8v7ls5g2pcazqyiwr-gpm-1.20.7/share/man/
strip is /nix/store/90vmpr41dzsx350k5argycaf693hnl1l-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/kvx6yia7i7jz8cf8v7ls5g2pcazqyiwr-gpm-1.20.7/lib  /nix/store/kvx6yia7i7jz8cf8v7ls5g2pcazqyiwr-gpm-1.20.7/bin  /nix/store/kvx6yia7i7jz8cf8v7ls5g2pcazqyiwr-gpm-1.20.7/sbin
patching script interpreter paths in /nix/store/kvx6yia7i7jz8cf8v7ls5g2pcazqyiwr-gpm-1.20.7
checking for references to /build in /nix/store/kvx6yia7i7jz8cf8v7ls5g2pcazqyiwr-gpm-1.20.7...
moving /nix/store/kvx6yia7i7jz8cf8v7ls5g2pcazqyiwr-gpm-1.20.7/sbin/* to /nix/store/kvx6yia7i7jz8cf8v7ls5g2pcazqyiwr-gpm-1.20.7/bin
/nix/store/kvx6yia7i7jz8cf8v7ls5g2pcazqyiwr-gpm-1.20.7

@dtzWill dtzWill merged commit ac55129 into NixOS:master Jul 19, 2018
@dtzWill dtzWill deleted the fix/gpm-musl branch July 19, 2018 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @GrahamcOfBorg