Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnome3.gjs: 1.52.3 -> 1.53.3 #43768

Closed
wants to merge 2 commits into from
Closed

gnome3.gjs: 1.52.3 -> 1.53.3 #43768

wants to merge 2 commits into from

Conversation

dpc
Copy link
Contributor

@dpc dpc commented Jul 18, 2018

Motivation for this change

I was told that the infamous gnome memory leak was finally fixed upstream:

https://bugs.launchpad.net/gnome-shell/+bug/1672297/comments/93

I am running this version on my work Ubuntu and it is a great improvement.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@dpc dpc changed the title Gjs 1.53.3 gnome3.gjs: 1.52.3 -> 1.53.3 Jul 18, 2018
@dpc
gnome3.gjs: 1.52.3 -> 1.53.3
618bb00 
I was told that the infamous gnome memory leak was finally fixed upstream:

https://bugs.launchpad.net/gnome-shell/+bug/1672297/comments/93
@GrahamcOfBorg GrahamcOfBorg added 6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 11-100 labels Jul 18, 2018
@jtojnar
Copy link
Contributor

jtojnar commented Jul 20, 2018

Please note that this is an unstable version.

Also 1.53.4 has been released:

https://gitlab.gnome.org/GNOME/gjs/blob/1.53.4/NEWS

@xeji
Copy link
Contributor

xeji commented Aug 1, 2018

@jtojnar so should we wait for a stable version?

@jtojnar
Copy link
Contributor

jtojnar commented Aug 1, 2018

I would just wait, gjs 1.53.4 is outdated already and the version after that is not backwards compatible. With GNOME 3.30 releasing in September, it is not a very long wait.

@xeji
Copy link
Contributor

xeji commented Aug 1, 2018

ok, marking this as WIP for now.

@jtojnar
Copy link
Contributor

jtojnar commented Sep 14, 2018

Closing in favor of #45950

@jtojnar jtojnar closed this Sep 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: work-in-progress 6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dpc @jtojnar @xeji @GrahamcOfBorg