Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lollypop: wrap search provider #43742

Closed
wants to merge 1 commit into from

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Just realized that there was a program lollypop-sp that wasn't wrapped.
It's a search provider so I think that's for Gnome so to test if it works it should show up as a search provider.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@worldofpeace worldofpeace mentioned this pull request Jul 22, 2018
9 tasks
@jtojnar
Copy link
Contributor

jtojnar commented Jul 22, 2018

@worldofpeace
Copy link
Contributor Author

Yeah you're right. Don't know why I didn't do that in the first place.

@worldofpeace
Copy link
Contributor Author

I still have to do some sort of manipulation to get it to wrap the program at libexec with python stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants