Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minecraft: clean and fix up #43774

Merged
merged 1 commit into from Jul 25, 2018
Merged

minecraft: clean and fix up #43774

merged 1 commit into from Jul 25, 2018

Conversation

infinisil
Copy link
Member

The launcher (now?) downloads almost all required libraries itself into
~/.minecraft and there's nothing one can do about it.

Pulseaudio is required for my sound to work. Would love to know if sound also works for somebody not using pulseaudio.

This reduces the closure size from 426MB to 269MB

ping @ryantm @cpages @aristidb @wkennington

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@infinisil
minecraft: clean and fix up
47f78cd 
The launcher now downloads almost all required libraries itself into
~/.minecraft and there's nothing one can do about it. Sound only works
with libpulseaudio though
@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: minecraft

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: minecraft

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@cpages cpages merged commit 4ccaa7d into NixOS:master Jul 25, 2018
@cpages
Copy link
Contributor

cpages commented Jul 25, 2018

Thanks. I think we can merge like this and act if someone complains about sound not working without pulse.

@infinisil infinisil deleted the fix/minecraft branch July 25, 2018 16:10
@infinisil infinisil mentioned this pull request Dec 1, 2018
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@infinisil @GrahamcOfBorg @cpages