Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lmms: 1.2.0-rc4 -> 1.2.0-rc6 #43584

Merged
merged 1 commit into from Jul 15, 2018
Merged

lmms: 1.2.0-rc4 -> 1.2.0-rc6 #43584

merged 1 commit into from Jul 15, 2018

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jul 15, 2018 •
edited

This fixes compilation. I can start it, but I have not test further then that.

cc @nek0

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92
lmms: 1.2.0-rc4 -> 1.2.0-rc6
d9d7422 
This fixes compilation
@Mic92 Mic92 requested a review from lukateras July 15, 2018 21:17
Mic92
Mic92 commented Jul 15, 2018
View reviewed changes
pkgs/applications/audio/lmms/default.nix

src = fetchFromGitHub {
owner = "LMMS";
repo = "lmms";
rev = "v${version}";
sha256 = "1n3py18zqbvfnkdiz4wc6z60xaajpkd3kn1wxmby5dmc4vccvjj5";
sha256 = "1pqir5srfrknfd8nmbz565ymq18ffw8d8k9pbmzggaxvlcr12b25";
fetchSubmodules = true;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was required because some some dependencies were vendored.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: lmms

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@lukateras lukateras merged commit fd3942b into NixOS:master Jul 15, 2018
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: lmms

Partial log (click to expand)

shrinking /nix/store/wvw5yj0ia2n4l77i5pswwv9ijmjv98q9-lmms-1.2.0-rc6/lib/lmms/libaudiofileprocessor.so
shrinking /nix/store/wvw5yj0ia2n4l77i5pswwv9ijmjv98q9-lmms-1.2.0-rc6/bin/lmms
gzipping man pages under /nix/store/wvw5yj0ia2n4l77i5pswwv9ijmjv98q9-lmms-1.2.0-rc6/share/man/
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/wvw5yj0ia2n4l77i5pswwv9ijmjv98q9-lmms-1.2.0-rc6/lib  /nix/store/wvw5yj0ia2n4l77i5pswwv9ijmjv98q9-lmms-1.2.0-rc6/bin
patching script interpreter paths in /nix/store/wvw5yj0ia2n4l77i5pswwv9ijmjv98q9-lmms-1.2.0-rc6
checking for references to /build in /nix/store/wvw5yj0ia2n4l77i5pswwv9ijmjv98q9-lmms-1.2.0-rc6...
postPatchMkspecs
postPatchMkspecs
/nix/store/wvw5yj0ia2n4l77i5pswwv9ijmjv98q9-lmms-1.2.0-rc6

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: lmms

Partial log (click to expand)

shrinking /nix/store/dvkd130fcq0idrf502jarfpd7zk704n6-lmms-1.2.0-rc6/lib/lmms/libamplifier.so
shrinking /nix/store/dvkd130fcq0idrf502jarfpd7zk704n6-lmms-1.2.0-rc6/bin/lmms
gzipping man pages under /nix/store/dvkd130fcq0idrf502jarfpd7zk704n6-lmms-1.2.0-rc6/share/man/
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/dvkd130fcq0idrf502jarfpd7zk704n6-lmms-1.2.0-rc6/lib  /nix/store/dvkd130fcq0idrf502jarfpd7zk704n6-lmms-1.2.0-rc6/bin
patching script interpreter paths in /nix/store/dvkd130fcq0idrf502jarfpd7zk704n6-lmms-1.2.0-rc6
checking for references to /build in /nix/store/dvkd130fcq0idrf502jarfpd7zk704n6-lmms-1.2.0-rc6...
postPatchMkspecs
postPatchMkspecs
/nix/store/dvkd130fcq0idrf502jarfpd7zk704n6-lmms-1.2.0-rc6

@lukateras lukateras mentioned this pull request Jul 16, 2018
Closed
@Mic92 Mic92 deleted the lmms branch July 16, 2018 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukateras lukateras lukateras approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mic92 @GrahamcOfBorg @lukateras