Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note that nixcrate is deprecated #43565

Closed
wants to merge 1 commit into from
Closed

Add note that nixcrate is deprecated #43565

wants to merge 1 commit into from

Conversation

kolloch
Copy link
Contributor

@kolloch kolloch commented Jul 15, 2018

Alternatively, remove it from the documentation

Motivation for this change

It seems that this is not a recommendable option anymore.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@kolloch
Add note that nixcrate is deprecated
424374f 
Alternatively, remove it from the documentation
@worldofpeace
Copy link
Contributor

Maybe just remove it from the docs completely. I don't think there should be references to deprecated software ever in the docs.

matthewbauer
matthewbauer previously approved these changes Jul 23, 2018
View reviewed changes
Copy link
Member

@matthewbauer matthewbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreeing with @worldofpeace here and going to say we should just remove the whole sentence.

matthewbauer
matthewbauer requested changes Jul 23, 2018
View reviewed changes
Copy link
Member

@matthewbauer matthewbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreeing with @worldofpeace here and going to say we should just remove the whole sentence.

@kolloch kolloch closed this Sep 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer requested changes

Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kolloch @worldofpeace @matthewbauer @GrahamcOfBorg