Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.cvxopt: enable tests #43566

Merged
merged 1 commit into from Jul 15, 2018
Merged

pythonPackages.cvxopt: enable tests #43566

merged 1 commit into from Jul 15, 2018

Conversation

timokau
Copy link
Member

@timokau timokau commented Jul 15, 2018

Motivation for this change

Reverts #43564, since the fix is in staging. To do that I also merged master into staging.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@timokau timokau requested a review from FRidh as a code owner July 15, 2018 10:26
@timokau timokau mentioned this pull request Jul 15, 2018
Merged
9 tasks
@timokau timokau changed the title Cvxopt enable tests pythonPackages.cvxopt: enable tests Jul 15, 2018
@dotlambda
Copy link
Member

I just merged master into staging, would you mind rebasing?

@timokau
pythonPackages.cvxopt: re-enable tests
ad74e10 
This reverts commit 64a64e7. The issue
was fixed in d2f0fc1.
@timokau
Copy link
Member Author

timokau commented Jul 15, 2018

Done

@dotlambda
Copy link
Member

@GrahamcOfBorg python2.pkgs.cvxopt python3.pkgs.cvxopt

@timokau
Copy link
Member Author

timokau commented Jul 15, 2018

Isn't it very likely to time out to let ofBorg build staging stuff?

@dotlambda
Copy link
Member

I was able to build it locally without a problem, but yes seems so. Let's just merge.

@dotlambda dotlambda merged commit 338f71a into NixOS:staging Jul 15, 2018
@timokau timokau deleted the cvxopt-enable-tests branch July 15, 2018 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@timokau @dotlambda @GrahamcOfBorg