ja2-stracciatella: 0.15.1 -> 0.16.1 #43567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
selaux
force-pushed
the
ja2-stracciatella-0.16.1
branch
from
0397a51
to
e013a50
Compare
samueldr
approved these changes
Aug 10, 2018
There was a problem hiding this comment.
I don't have the data files to launch it, but the binary does work, and the launcher does show its window.
The updated derivation looks fine, not 100% sure if there's anything weird or wrong with the structure with regards to how libstracciatella is built, but I personally don't think there's anything wrong. For now, I'll defer this judgement to someone with more experience though.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Package update. Now uses rust for some parts of the application and has additional dependencies. It would be nice to find another way to inject the lockfile into the rust packages source, but I couldn't as
buildRustPackageseems to ignore custom unpack phases (or I'm too stupid to do that). I also had to disable tests for the rust package as they are flaky.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)