Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mpv: add Cocoa support for macOS #43598

Merged
merged 1 commit into from Jul 16, 2018
Merged

mpv: add Cocoa support for macOS #43598

merged 1 commit into from Jul 16, 2018

Conversation

Enzime
Copy link
Member

@Enzime Enzime commented Jul 16, 2018

Only enable X11 Support on Linux by default. Add CoreFoundation first in
the list of buildInputs to ensure that it is loaded before CF-osx
allowing it to provide <CoreFoundation/CFAttributedString.h>.

Things done
  • Tested without using sandboxing on macOS
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Enzime
mpv: add Cocoa support for macOS
2dd3a9d 
Only enable X11 Support on Linux by default. Add CoreFoundation first in
the list of buildInputs to ensure that it is loaded before CF-osx
allowing it to provide <CoreFoundation/CFAttributedString.h>.
@fpletz
Copy link
Member

fpletz commented Jul 16, 2018

@GrahamcOfBorg build mpv

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: mpv

Partial log (click to expand)

/nix/store/xkr1l74b7mgi8wndfzbw2yawj0ga1xh3-mpv-0.28.2/lib/libmpv.1.26.0.dylib: fixing dylib
/nix/store/xkr1l74b7mgi8wndfzbw2yawj0ga1xh3-mpv-0.28.2/lib/libmpv.1.26.0.dylib: fixing dylib
/nix/store/xkr1l74b7mgi8wndfzbw2yawj0ga1xh3-mpv-0.28.2/lib/libmpv.1.26.0.dylib: fixing dylib
/nix/store/xkr1l74b7mgi8wndfzbw2yawj0ga1xh3-mpv-0.28.2/lib/libmpv.1.26.0.dylib: fixing dylib
/nix/store/xkr1l74b7mgi8wndfzbw2yawj0ga1xh3-mpv-0.28.2/lib/libmpv.1.26.0.dylib: fixing dylib
/nix/store/xkr1l74b7mgi8wndfzbw2yawj0ga1xh3-mpv-0.28.2/lib/libmpv.1.26.0.dylib: fixing dylib
/nix/store/xkr1l74b7mgi8wndfzbw2yawj0ga1xh3-mpv-0.28.2/lib/libmpv.1.26.0.dylib: fixing dylib
/nix/store/xkr1l74b7mgi8wndfzbw2yawj0ga1xh3-mpv-0.28.2/lib/libmpv.1.26.0.dylib: fixing dylib
/nix/store/xkr1l74b7mgi8wndfzbw2yawj0ga1xh3-mpv-0.28.2/lib/libmpv.1.26.0.dylib: fixing dylib
/nix/store/xkr1l74b7mgi8wndfzbw2yawj0ga1xh3-mpv-0.28.2/lib/libmpv.1.26.0.dylib: fixing dylib

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: mpv

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/xcp08lyw1j5pghb39y0mwjxds84ls43c-mpv-0.28.2
shrinking /nix/store/xcp08lyw1j5pghb39y0mwjxds84ls43c-mpv-0.28.2/lib/libmpv.so.1.26.0
shrinking /nix/store/xcp08lyw1j5pghb39y0mwjxds84ls43c-mpv-0.28.2/bin/.mpv-wrapped
gzipping man pages under /nix/store/xcp08lyw1j5pghb39y0mwjxds84ls43c-mpv-0.28.2/share/man/
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/xcp08lyw1j5pghb39y0mwjxds84ls43c-mpv-0.28.2/lib  /nix/store/xcp08lyw1j5pghb39y0mwjxds84ls43c-mpv-0.28.2/bin
patching script interpreter paths in /nix/store/xcp08lyw1j5pghb39y0mwjxds84ls43c-mpv-0.28.2
checking for references to /build in /nix/store/xcp08lyw1j5pghb39y0mwjxds84ls43c-mpv-0.28.2...
/nix/store/xcp08lyw1j5pghb39y0mwjxds84ls43c-mpv-0.28.2

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: mpv

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/1vx2q2fmxxs89c8h2a3i0fjsvgrp6s4f-mpv-0.28.2
shrinking /nix/store/1vx2q2fmxxs89c8h2a3i0fjsvgrp6s4f-mpv-0.28.2/bin/.mpv-wrapped
shrinking /nix/store/1vx2q2fmxxs89c8h2a3i0fjsvgrp6s4f-mpv-0.28.2/lib/libmpv.so.1.26.0
gzipping man pages under /nix/store/1vx2q2fmxxs89c8h2a3i0fjsvgrp6s4f-mpv-0.28.2/share/man/
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/1vx2q2fmxxs89c8h2a3i0fjsvgrp6s4f-mpv-0.28.2/lib  /nix/store/1vx2q2fmxxs89c8h2a3i0fjsvgrp6s4f-mpv-0.28.2/bin
patching script interpreter paths in /nix/store/1vx2q2fmxxs89c8h2a3i0fjsvgrp6s4f-mpv-0.28.2
checking for references to /build in /nix/store/1vx2q2fmxxs89c8h2a3i0fjsvgrp6s4f-mpv-0.28.2...
/nix/store/1vx2q2fmxxs89c8h2a3i0fjsvgrp6s4f-mpv-0.28.2

@fpletz fpletz merged commit 152f608 into NixOS:master Jul 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Enzime @fpletz @GrahamcOfBorg