Add Dell E7240 Profile #64
Conversation
(Current XPS 15 works well)
dell/e7240/default.nix
Outdated
| ]; | ||
|
|
||
| boot.loader.systemd-boot.enable = lib.mkDefault true; | ||
| boot.loader.efi.canTouchEfiVariables = lib.mkDefault true; |
There was a problem hiding this comment.
Do you think these two lines are required? It is also part of the generator:
There was a problem hiding this comment.
Hmm, not sure. I replace everything in the generator so was useful for me. Also, this is in the XPS13 setup. So I think it's best to have it here, but if you disagree I wouldn't argue against it.
There was a problem hiding this comment.
The second line is something one might not want to have by default enabled: #68 (comment)
There was a problem hiding this comment.
Good call.
But still, what about the first. I assume you do actually still want this generally for this laptop?
kernelPackages and pusleaudio.
|
So I added pulseaudio and I have found that to fix a bug with suspending, you need to use an older kernel version. Only, the available kernel versions change from nixpkgs to nixpkgs, so this may not be actually desirable to specify. |
dell/e7240/default.nix
Outdated
| ../../../common/pc/laptop | ||
| ]; | ||
|
|
||
| boot.loader.systemd-boot.enable = lib.mkDefault true; |
There was a problem hiding this comment.
What if the user has already installed grub?
dell/e7240/default.nix
Outdated
|
|
||
| boot.loader.systemd-boot.enable = lib.mkDefault true; | ||
|
|
||
| hardware.pulseaudio.enable = true; |
There was a problem hiding this comment.
We usually try avoid opinionated configuration like the sound system. https://github.com/NixOS/nixos-hardware/blob/master/CONTRIBUTING.md#writing-profiles
Why was this necessary?
|
Agree, too opinionated IMO. The problem "doesn't work on kernel XXX" should be solved in a more generic way. Maybe just write a note in README: "if you experience problems with suspend, try setting older (4.14) kernel". It may also be wrong to use old kernel next year - fix may be upstreamed already. @ashgillman what do you think? |
|
I think all previous comments are fair. I have updated, moving kernel choice to a comment. |
Link e7240 readme in main readme Co-Authored-By: ashgillman <gillmanash@gmail.com>
|
Was merged here: https://github.com/NixOS/nixos-hardware/pull/122/files |
Current XPS 15 profile works well for Dell E7240 ultrabook.