Improve dev env #574
Closed
Improve dev env #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is basically stuff I found out during several times I contributed minor things to Hydra. This patch adds several files to `.gitignore` to ensure that one doesn't add random stuff accidentally to their commit. Also improved the shellHook to set all required environment variables and to check if there's a postgresql available (optionally one can start a simple instance in a nixos-container using `test-database.nix`).
|
@edolstra from my PoV this helps contributors to set up a dev environment to hack on Hydra. Is there anything that keeps this from getting merged? :) |
|
Just gave this a shot and ran into this: I guess that is expected but should probably documented. |
|
Oh yeah, there's a |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two commits with the attempt to make bootstrapping and hacking on Hydra easier. Until now it missed to mention hydra-init and setting the env vars accordingly.
Please note that this PR is highly opinionated and it probably shouldn't merged as-is to master. However it may help other folks to get started with contributing to Hydra even faster.
Update from 2019-11-02 (after adding postgresql support):
This is basically stuff I found out during several times I contributed
minor things to Hydra. This patch adds several files to
.gitignoretoensure that one doesn't add random stuff accidentally to their commit.
Also improved the shellHook to set all required environment variables
and to check if there's a postgresql available (optionally one can start
a simple instance in a nixos-container using
test-database.nix).