Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xkbcomp: 1.4.0 -> 1.4.2 #43589

Merged
merged 1 commit into from Jul 16, 2018
Merged

xkbcomp: 1.4.0 -> 1.4.2 #43589

merged 1 commit into from Jul 16, 2018

Conversation

lukateras
Copy link
Member

@lukateras lukateras commented Jul 15, 2018 •
edited

Motivation for this change

5bdd9bd broke keyboard layout switch in XWayland sessions, which is caused by incompatibility betwen xkeyboardconfig 2.24 and xkbcomp 1.4.0. This issue is fixed in xkbcomp 1.4.2.

See: https://bugzilla.redhat.com/show_bug.cgi?id=1587998

I've rebuilt my system on top of this change.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Jul 16, 2018

@GrahamcOfBorg build xorg.xkbcomp

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: xorg.xkbcomp

Partial log (click to expand)

 /nix/store/5q51r2d0xzs4hi8rb661drpf83mhm4b4-coreutils-8.29/bin/install -c -m 644 xkbcomp.pc '/nix/store/akkmqqfm87c1ydm7aniq3k75jjcdc41h-xkbcomp-1.4.2/lib/pkgconfig'
make[2]: Leaving directory '/private/tmp/nix-build-xkbcomp-1.4.2.drv-0/xkbcomp-1.4.2'
make[1]: Leaving directory '/private/tmp/nix-build-xkbcomp-1.4.2.drv-0/xkbcomp-1.4.2'
propagating requisites
post-installation fixup
gzipping man pages under /nix/store/akkmqqfm87c1ydm7aniq3k75jjcdc41h-xkbcomp-1.4.2/share/man/
strip is /nix/store/7ddbq63v97nk8gkbf7gcsfmby37h6gbl-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/akkmqqfm87c1ydm7aniq3k75jjcdc41h-xkbcomp-1.4.2/lib  /nix/store/akkmqqfm87c1ydm7aniq3k75jjcdc41h-xkbcomp-1.4.2/bin
patching script interpreter paths in /nix/store/akkmqqfm87c1ydm7aniq3k75jjcdc41h-xkbcomp-1.4.2
/nix/store/akkmqqfm87c1ydm7aniq3k75jjcdc41h-xkbcomp-1.4.2

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: xorg.xkbcomp

Partial log (click to expand)

propagating requisites
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/3vfm5myibmlw7rjwwx6xmrm46agg55l3-xkbcomp-1.4.2
shrinking /nix/store/3vfm5myibmlw7rjwwx6xmrm46agg55l3-xkbcomp-1.4.2/bin/xkbcomp
gzipping man pages under /nix/store/3vfm5myibmlw7rjwwx6xmrm46agg55l3-xkbcomp-1.4.2/share/man/
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/3vfm5myibmlw7rjwwx6xmrm46agg55l3-xkbcomp-1.4.2/lib  /nix/store/3vfm5myibmlw7rjwwx6xmrm46agg55l3-xkbcomp-1.4.2/bin
patching script interpreter paths in /nix/store/3vfm5myibmlw7rjwwx6xmrm46agg55l3-xkbcomp-1.4.2
checking for references to /build in /nix/store/3vfm5myibmlw7rjwwx6xmrm46agg55l3-xkbcomp-1.4.2...
/nix/store/3vfm5myibmlw7rjwwx6xmrm46agg55l3-xkbcomp-1.4.2

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: xorg.xkbcomp

Partial log (click to expand)

propagating requisites
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/2iahxr4wmz24x0g2633ww7x9d4bpl6r4-xkbcomp-1.4.2
shrinking /nix/store/2iahxr4wmz24x0g2633ww7x9d4bpl6r4-xkbcomp-1.4.2/bin/xkbcomp
gzipping man pages under /nix/store/2iahxr4wmz24x0g2633ww7x9d4bpl6r4-xkbcomp-1.4.2/share/man/
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/2iahxr4wmz24x0g2633ww7x9d4bpl6r4-xkbcomp-1.4.2/lib  /nix/store/2iahxr4wmz24x0g2633ww7x9d4bpl6r4-xkbcomp-1.4.2/bin
patching script interpreter paths in /nix/store/2iahxr4wmz24x0g2633ww7x9d4bpl6r4-xkbcomp-1.4.2
checking for references to /build in /nix/store/2iahxr4wmz24x0g2633ww7x9d4bpl6r4-xkbcomp-1.4.2...
/nix/store/2iahxr4wmz24x0g2633ww7x9d4bpl6r4-xkbcomp-1.4.2

@xeji xeji merged commit c9a1e46 into NixOS:master Jul 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lukateras @xeji @GrahamcOfBorg @infinisil