Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

percona-toolkit: init at 3.0.11 #43568

Merged
merged 1 commit into from Jul 16, 2018
Merged

percona-toolkit: init at 3.0.11 #43568

merged 1 commit into from Jul 16, 2018

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Jul 15, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

pSub
pSub requested changes Jul 15, 2018
View reviewed changes
pkgs/top-level/perl-packages.nix Outdated
rev = "${version}";
sha256 = "18wxvp7psqrx0zdvg47azrals572hv9fx1s3p0q65s87lnk3q63l";
};
outputs = [ "out" ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out is the default output. You don't have to specify it here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error build without utputs = [ "out" ]; -
nix build -f ~/works/src-nix/nixpkgs-my perlPackages.PerconaToolkit
builder for '/nix/store/6vv63471a14kdpprsrpa51g5gm1kwdhd-perl-Percona-Toolkit-3.0.11.drv' failed to produce output path '/nix/store/yx40qkihv0rm3psccm5d53j2pi0mxf19-perl-Percona-Toolkit-3.0.11-devdoc'
[0 built (1 failed), 0.0 MiB DL]
error: build of '/nix/store/6vv63471a14kdpprsrpa51g5gm1kwdhd-perl-Percona-Toolkit-3.0.11.drv' failed

pkgs/top-level/perl-packages.nix Outdated
src = fetchFromGitHub {
owner = "percona";
repo = "percona-toolkit";
rev = "${version}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I am missing it, but where do you declare variable version. I only see name = "Percona-Toolkit-3.0.11";.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@Izorkin
Copy link
Contributor Author

Izorkin commented Jul 15, 2018

cc @pSub Fixed commit.

@pSub pSub merged commit 235bd2b into NixOS:master Jul 16, 2018
@Izorkin
Copy link
Contributor Author

Izorkin commented Jul 16, 2018

Thanks!

@Izorkin Izorkin deleted the percona-toolkit branch July 16, 2018 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pSub pSub pSub requested changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Izorkin @pSub @GrahamcOfBorg