Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xlog: init at 2.0.15 #43606

Merged
merged 1 commit into from Jul 19, 2018
Merged

xlog: init at 2.0.15 #43606

merged 1 commit into from Jul 19, 2018

Conversation

MarcFontaine
Copy link
Contributor

Motivation for this change

I would like to add xlog to nixpkgs

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • [ X] Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

nlewo
nlewo requested changes Jul 17, 2018
View reviewed changes
pkgs/applications/misc/xlog/default.nix Outdated
buildInputs = [glib pkgconfig gtk2 hamlib];

meta = with stdenv.lib; {
description = "an amateur radio logging program";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please upper case the first letter

pkgs/applications/misc/xlog/default.nix Outdated
sha256 = "0an883wqw3zwpw8nqinm9cb17hp2xw9vf603k4l2345p61jqdw2j";
};

buildInputs = [glib pkgconfig gtk2 hamlib];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non blocking: spaces arround [ -> [ glib pkgconfig gtk2 hamlib ]

pkgs/applications/misc/xlog/default.nix Outdated
location in latitude and longitude and distance and heading in kilometers or miles,
both for short and long path.
'';
homepage = "http://www.nongnu.org/xlog";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No quotes arround urls.

@MarcFontaine
Copy link
Contributor Author

Thanks for the review.
I have included the changes

@nlewo
Copy link
Member

nlewo commented Jul 19, 2018

@GrahamcOfBorg build xlog

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: xlog

Partial log (click to expand)

glibPreFixupPhase
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/jzp12rm38xqjqvjhrkiwlnzj5cx587dp-xlog-2.0.15
shrinking /nix/store/jzp12rm38xqjqvjhrkiwlnzj5cx587dp-xlog-2.0.15/bin/xlog
gzipping man pages under /nix/store/jzp12rm38xqjqvjhrkiwlnzj5cx587dp-xlog-2.0.15/share/man/
strip is /nix/store/90vmpr41dzsx350k5argycaf693hnl1l-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/jzp12rm38xqjqvjhrkiwlnzj5cx587dp-xlog-2.0.15/bin
patching script interpreter paths in /nix/store/jzp12rm38xqjqvjhrkiwlnzj5cx587dp-xlog-2.0.15
checking for references to /build in /nix/store/jzp12rm38xqjqvjhrkiwlnzj5cx587dp-xlog-2.0.15...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: xlog

Partial log (click to expand)

glibPreFixupPhase
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/qxp53q2f9h3j25lgd750fpmxg63xjyn7-xlog-2.0.15
shrinking /nix/store/qxp53q2f9h3j25lgd750fpmxg63xjyn7-xlog-2.0.15/bin/xlog
gzipping man pages under /nix/store/qxp53q2f9h3j25lgd750fpmxg63xjyn7-xlog-2.0.15/share/man/
strip is /nix/store/7iyn7gn33i7xxjgmwf25k20246y6nd9d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/qxp53q2f9h3j25lgd750fpmxg63xjyn7-xlog-2.0.15/bin
patching script interpreter paths in /nix/store/qxp53q2f9h3j25lgd750fpmxg63xjyn7-xlog-2.0.15
checking for references to /build in /nix/store/qxp53q2f9h3j25lgd750fpmxg63xjyn7-xlog-2.0.15...

@nlewo
Copy link
Member

nlewo commented Jul 19, 2018

Thx!

@nlewo nlewo merged commit fd3b874 into NixOS:master Jul 19, 2018
@MarcFontaine MarcFontaine deleted the xlog branch July 19, 2018 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlewo nlewo nlewo requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MarcFontaine @nlewo @GrahamcOfBorg