Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nethack: add qt support on linux #43558

Merged
merged 2 commits into from Jul 19, 2018
Merged

nethack: add qt support on linux #43558

merged 2 commits into from Jul 19, 2018

Conversation

herberteuler
Copy link
Member

@herberteuler herberteuler commented Jul 15, 2018 •
edited

Motivation for this change

Add Qt 5 support on Linux. Note that Qt 5 support is not available on Mac OS since upstream does not support this yet.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

fpletz
fpletz approved these changes Jul 15, 2018
View reviewed changes
Copy link
Member

@fpletz fpletz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 👍

Added a commit for wrapping the Qt plugin search path so it will still work if the Qt version of the system/environment is different.

@matthewbauer matthewbauer merged commit 26cd7bb into NixOS:master Jul 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz fpletz approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@herberteuler @fpletz @matthewbauer @GrahamcOfBorg