Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eclib: 20171219 -> 20180710 #43563

Merged
merged 1 commit into from Jul 15, 2018
Merged

eclib: 20171219 -> 20180710 #43563

merged 1 commit into from Jul 15, 2018

Conversation

timokau
Copy link
Member

@timokau timokau commented Jul 15, 2018

Motivation for this change

Since this should build just fine on darwin, I've experimentally removed the platforms restriction. Lets see what ofborg says.

I'm still running the sage tests locally, so don't merge just yet.

closes #43476

@7c6f434c

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: eclib

Partial log (click to expand)

shrinking /nix/store/xq6y4znivp7wxznghiqanbhlc3ih3xb3-eclib-20180710/bin/reduce_quartics
shrinking /nix/store/xq6y4znivp7wxznghiqanbhlc3ih3xb3-eclib-20180710/bin/mwrank
shrinking /nix/store/xq6y4znivp7wxznghiqanbhlc3ih3xb3-eclib-20180710/bin/aplist
shrinking /nix/store/xq6y4znivp7wxznghiqanbhlc3ih3xb3-eclib-20180710/lib/libec.so.4.0.0
gzipping man pages under /nix/store/xq6y4znivp7wxznghiqanbhlc3ih3xb3-eclib-20180710/share/man/
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/xq6y4znivp7wxznghiqanbhlc3ih3xb3-eclib-20180710/lib  /nix/store/xq6y4znivp7wxznghiqanbhlc3ih3xb3-eclib-20180710/bin 
patching script interpreter paths in /nix/store/xq6y4znivp7wxznghiqanbhlc3ih3xb3-eclib-20180710
checking for references to /tmp/nix-build-eclib-20180710.drv-0 in /nix/store/xq6y4znivp7wxznghiqanbhlc3ih3xb3-eclib-20180710...
/nix/store/xq6y4znivp7wxznghiqanbhlc3ih3xb3-eclib-20180710

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: eclib

Partial log (click to expand)

make[2]: Nothing to be done for 'install-exec-am'.
make[2]: Nothing to be done for 'install-data-am'.
make[2]: Leaving directory '/private/tmp/nix-build-eclib-20180710.drv-0/source'
make[1]: Leaving directory '/private/tmp/nix-build-eclib-20180710.drv-0/source'
post-installation fixup
gzipping man pages under /nix/store/ici78hid2dg4ijsjs9p72fiv4r8drzaw-eclib-20180710/share/man/
strip is /nix/store/7ddbq63v97nk8gkbf7gcsfmby37h6gbl-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/ici78hid2dg4ijsjs9p72fiv4r8drzaw-eclib-20180710/lib  /nix/store/ici78hid2dg4ijsjs9p72fiv4r8drzaw-eclib-20180710/bin
patching script interpreter paths in /nix/store/ici78hid2dg4ijsjs9p72fiv4r8drzaw-eclib-20180710
/nix/store/ici78hid2dg4ijsjs9p72fiv4r8drzaw-eclib-20180710

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: eclib

Partial log (click to expand)

shrinking /nix/store/ps7rlljyl2v6jl9dm1xswrqg9v5h73gf-eclib-20180710/bin/reduce_cubics
shrinking /nix/store/ps7rlljyl2v6jl9dm1xswrqg9v5h73gf-eclib-20180710/bin/solve_legendre
shrinking /nix/store/ps7rlljyl2v6jl9dm1xswrqg9v5h73gf-eclib-20180710/bin/solve_conic
shrinking /nix/store/ps7rlljyl2v6jl9dm1xswrqg9v5h73gf-eclib-20180710/lib/libec.so.4.0.0
gzipping man pages under /nix/store/ps7rlljyl2v6jl9dm1xswrqg9v5h73gf-eclib-20180710/share/man/
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ps7rlljyl2v6jl9dm1xswrqg9v5h73gf-eclib-20180710/lib  /nix/store/ps7rlljyl2v6jl9dm1xswrqg9v5h73gf-eclib-20180710/bin
patching script interpreter paths in /nix/store/ps7rlljyl2v6jl9dm1xswrqg9v5h73gf-eclib-20180710
checking for references to /build in /nix/store/ps7rlljyl2v6jl9dm1xswrqg9v5h73gf-eclib-20180710...
/nix/store/ps7rlljyl2v6jl9dm1xswrqg9v5h73gf-eclib-20180710

@7c6f434c
Copy link
Member

Seems OK, waiting for the test results.

@timokau
eclib: 20171219 -> 20180710
c77d1e5 
Also includes the necessary sage compatibility patch, borrowed from
ArchLinux.
@timokau timokau requested a review from FRidh as a code owner July 15, 2018 13:15
@timokau
Copy link
Member Author

timokau commented Jul 15, 2018

There was one more cosmetical issue, now its ready to go :)

I also added a comment mentioning which sage tests are likely to fail. I think this would be another nice use-case for #36842: Since dependencies usually break at the interface, it should be possible to make a quick individualized "did this break sage" check for every dependency that is likely to do so.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: eclib

Partial log (click to expand)

/nix/store/ps7rlljyl2v6jl9dm1xswrqg9v5h73gf-eclib-20180710

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: eclib

Partial log (click to expand)

/nix/store/ici78hid2dg4ijsjs9p72fiv4r8drzaw-eclib-20180710

@7c6f434c 7c6f434c merged commit 10ffc3c into NixOS:master Jul 15, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: eclib

Partial log (click to expand)

shrinking /nix/store/xq6y4znivp7wxznghiqanbhlc3ih3xb3-eclib-20180710/bin/list_cubics
shrinking /nix/store/xq6y4znivp7wxznghiqanbhlc3ih3xb3-eclib-20180710/bin/indep_test
shrinking /nix/store/xq6y4znivp7wxznghiqanbhlc3ih3xb3-eclib-20180710/bin/ecnf
shrinking /nix/store/xq6y4znivp7wxznghiqanbhlc3ih3xb3-eclib-20180710/bin/nfhpmcurve
gzipping man pages under /nix/store/xq6y4znivp7wxznghiqanbhlc3ih3xb3-eclib-20180710/share/man/
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/xq6y4znivp7wxznghiqanbhlc3ih3xb3-eclib-20180710/lib  /nix/store/xq6y4znivp7wxznghiqanbhlc3ih3xb3-eclib-20180710/bin
patching script interpreter paths in /nix/store/xq6y4znivp7wxznghiqanbhlc3ih3xb3-eclib-20180710
checking for references to /build in /nix/store/xq6y4znivp7wxznghiqanbhlc3ih3xb3-eclib-20180710...
/nix/store/xq6y4znivp7wxznghiqanbhlc3ih3xb3-eclib-20180710

@timokau timokau deleted the eclib-20180710 branch July 15, 2018 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@timokau @GrahamcOfBorg @7c6f434c