Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bluemix-cli: 0.6.6 -> 0.8.0 #43605

Merged
merged 1 commit into from Jul 16, 2018
Merged

bluemix-cli: 0.6.6 -> 0.8.0 #43605

merged 1 commit into from Jul 16, 2018

Conversation

jensbin
Copy link
Contributor

@jensbin jensbin commented Jul 16, 2018 •
edited

Motivation for this change
  • Upstream version update
  • Added platform Linux32
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@jensbin jensbin force-pushed the bluemix branch 2 times, most recently from 487e43e to fe47777 Compare July 16, 2018 09:31
@xeji
Copy link
Contributor

xeji commented Jul 16, 2018

Did you test this on darwin and i686 ?

/cc @tazjin

@jensbin
Copy link
Contributor Author

jensbin commented Jul 16, 2018

@xeji , Unfortunately not. Only verified the presents of the archive and binaries.

@xeji
Copy link
Contributor

xeji commented Jul 16, 2018

No problem, I just wanted your answer documented here for reference.
I checked the build for x86_64-linux and i686-linux locally (but didn't test the app itself, don't use IBM cloud).

@jensbin
Copy link
Contributor Author

jensbin commented Jul 16, 2018

Thanks, appreciated! Will add the test status the next time.

tazjin
tazjin approved these changes Jul 16, 2018
View reviewed changes
Copy link
Member

@tazjin tazjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I don't have 32-bit & OS X platforms to test on. Feel free to add yourself to the maintainer list, too, @jensbin.

@jensbin
Copy link
Contributor Author

jensbin commented Jul 16, 2018

@tazjin , @xeji Thanks for the input. I decided to remove the darwin part, because I checked the installer and I am not sure if it would work and I can't test.

@xeji xeji merged commit 23b2b49 into NixOS:master Jul 16, 2018
@jensbin jensbin deleted the bluemix branch July 16, 2018 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tazjin tazjin tazjin approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jensbin @xeji @tazjin @GrahamcOfBorg