Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cataclysm dda 2018-07-15 #43578

Merged
merged 2 commits into from Jul 15, 2018
Merged

cataclysm dda 2018-07-15 #43578

merged 2 commits into from Jul 15, 2018

Conversation

rardiol
Copy link
Contributor

@rardiol rardiol commented Jul 15, 2018

Motivation for this change

Considering this game's propensity towards segfault, a easy debug flag seemed useful.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@fpletz
Copy link
Member

fpletz commented Jul 15, 2018

@GrahamcOfBorg build cataclysm-dda-git

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: cataclysm-dda-git

Partial log (click to expand)

mkdir -p /nix/store/fbjwzhzznqi3ysa00bfnwmmwn14qjmw3-cataclysm-dda-git-2018-07-15/share/locale
LOCALE_DIR=/nix/store/fbjwzhzznqi3ysa00bfnwmmwn14qjmw3-cataclysm-dda-git-2018-07-15/share/locale lang/compile_mo.sh all
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/fbjwzhzznqi3ysa00bfnwmmwn14qjmw3-cataclysm-dda-git-2018-07-15
shrinking /nix/store/fbjwzhzznqi3ysa00bfnwmmwn14qjmw3-cataclysm-dda-git-2018-07-15/bin/cataclysm-tiles
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/fbjwzhzznqi3ysa00bfnwmmwn14qjmw3-cataclysm-dda-git-2018-07-15/bin
patching script interpreter paths in /nix/store/fbjwzhzznqi3ysa00bfnwmmwn14qjmw3-cataclysm-dda-git-2018-07-15
checking for references to /build in /nix/store/fbjwzhzznqi3ysa00bfnwmmwn14qjmw3-cataclysm-dda-git-2018-07-15...
/nix/store/fbjwzhzznqi3ysa00bfnwmmwn14qjmw3-cataclysm-dda-git-2018-07-15

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: cataclysm-dda-git

Partial log (click to expand)

install --mode=644 data/changelog.txt data/cataicon.ico data/fontdata.json \
                   LICENSE.txt -t /nix/store/fyv2gk95zm21jfjrmlgk1g1yr852rd85-cataclysm-dda-git-2018-07-15/share/cataclysm-dda/
mkdir -p /nix/store/fyv2gk95zm21jfjrmlgk1g1yr852rd85-cataclysm-dda-git-2018-07-15/share/locale
LOCALE_DIR=/nix/store/fyv2gk95zm21jfjrmlgk1g1yr852rd85-cataclysm-dda-git-2018-07-15/share/locale lang/compile_mo.sh all
post-installation fixup
strip is /nix/store/7ddbq63v97nk8gkbf7gcsfmby37h6gbl-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/fyv2gk95zm21jfjrmlgk1g1yr852rd85-cataclysm-dda-git-2018-07-15/bin
patching script interpreter paths in /nix/store/fyv2gk95zm21jfjrmlgk1g1yr852rd85-cataclysm-dda-git-2018-07-15
/nix/store/fyv2gk95zm21jfjrmlgk1g1yr852rd85-cataclysm-dda-git-2018-07-15/Applications/Cataclysm.app/Contents/MacOS/Cataclysm.sh: interpreter directive changed from "/bin/sh" to "/nix/store/q2wqq1k20v8kc3vckapqf5nws30brnni-bash-4.4-p23/bin/sh"
/nix/store/fyv2gk95zm21jfjrmlgk1g1yr852rd85-cataclysm-dda-git-2018-07-15

@fpletz fpletz merged commit a2eb170 into NixOS:master Jul 15, 2018
@rardiol rardiol deleted the cdda branch July 15, 2018 21:13
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: cataclysm-dda-git

Partial log (click to expand)

mkdir -p /nix/store/85l1kga62c5wxhzcs82ry2nwfj0qi36g-cataclysm-dda-git-2018-07-15/share/locale
LOCALE_DIR=/nix/store/85l1kga62c5wxhzcs82ry2nwfj0qi36g-cataclysm-dda-git-2018-07-15/share/locale lang/compile_mo.sh all
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/85l1kga62c5wxhzcs82ry2nwfj0qi36g-cataclysm-dda-git-2018-07-15
shrinking /nix/store/85l1kga62c5wxhzcs82ry2nwfj0qi36g-cataclysm-dda-git-2018-07-15/bin/cataclysm-tiles
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/85l1kga62c5wxhzcs82ry2nwfj0qi36g-cataclysm-dda-git-2018-07-15/bin
patching script interpreter paths in /nix/store/85l1kga62c5wxhzcs82ry2nwfj0qi36g-cataclysm-dda-git-2018-07-15
checking for references to /build in /nix/store/85l1kga62c5wxhzcs82ry2nwfj0qi36g-cataclysm-dda-git-2018-07-15...
/nix/store/85l1kga62c5wxhzcs82ry2nwfj0qi36g-cataclysm-dda-git-2018-07-15

@mnacamura mnacamura mentioned this pull request Jul 17, 2018
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rardiol @fpletz @GrahamcOfBorg